Skip to content

feat(empty-strings): drop empty string strictness to allow new empty string feature - #322

Merged
michaelwittwer merged 1 commit into
shiftcode:nextfrom
holiday-fox:allow-empty-string
Sep 3, 2020
Merged

feat(empty-strings): drop empty string strictness to allow new empty string feature#322
michaelwittwer merged 1 commit into
shiftcode:nextfrom
holiday-fox:allow-empty-string

Conversation

@hookercookerman

Copy link
Copy Markdown
Contributor

What

  • String Mapper now allows empty strings

Why

  • Dynamodb has added support for empty strings, this can be vey helpful on updates where you could be looking for deletions and defaults.

@michaelwittwer

Copy link
Copy Markdown
Member

@hookercookerman thanks for the contribution, this is awesome. Will try to bring back the PR as soon as possible. (probably start of next week). Reach out if it is really urgent on your side.

@michaelwittwer
michaelwittwer self-requested a review July 16, 2020 12:33

@michaelwittwermichaelwittwer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hookercookerman could you resolve the one minor issue commented by @simonmumenthaler then this is ready to come back to the master

@hookercookerman

Copy link
Copy Markdown
ContributorAuthor

@michaellieberherr will do I should have time tomorrow BTW this pr is not ready as it does not cater for stringFromDb when empty string which can hamper mappings when empty string; classic empty string as falsey.

@hookercookerman

Copy link
Copy Markdown
ContributorAuthor

@michaelwittwer soz for delay but updated, cheers

michaelwittwer
michaelwittwer previously approved these changes Aug 13, 2020
@michaelwittwer
michaelwittwer dismissed their stale reviewAugust 13, 2020 14:55

this change introduces non backwards compatible changes, so this needs to be a breaking change

@michaelwittwer
michaelwittwer self-requested a review August 13, 2020 14:56

@michaelwittwermichaelwittwer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change introduces non backwards compatible changes, so this needs to be a breaking change.

can you change your commit message as follows:

feat(empty-strings): allow empty string toDb and from
BREAKING CHANGE: empty strings are now valid dynamoDB values (see https://aws.amazon.com/about-aws/whats-new/2020/05/amazon-dynamodb-now-supports-empty-values-for-non-key-string-and-binary-attributes-in-dynamodb-tables/ for official statement) and thus they are mapped to and from db.

then we are finally ready to bring this back.

@hookercookerman
hookercookerman dismissed a stale review via c1b8a42August 13, 2020 15:30
@michaelwittwer
michaelwittwer changed the base branch from master to nextSeptember 3, 2020 06:25
@michaelwittwer
michaelwittwer merged commit 7420346 into shiftcode:nextSep 3, 2020
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 6.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@hookercookerman@michaelwittwer