Uh oh!
There was an error while loading. Please reload this page.
Support EgressIP role in shiftstack-qa automation - #10
Conversation
imatza-rh
left a comment
There was a problem hiding this comment.
Nice work porting the EgressIP tests. A few items to address before CI:
1. Private repo clone will fail
The shared prepare_openshift_tests.yml clones via unauthenticated HTTPS. openshift-tests-private is a private repo and will 404. The IR plugin handles this with SSH + deploy key for private repos. We need a similar mechanism in our shared role.
Since shiftstack-qa is a public repo, the deploy key can't be committed as plaintext like the IR plugin does. It should go into configs/secret.yaml (vault-encrypted) or be injected via CI secrets.
2. Build commandmake WHAT=cmd/openshift-tests (run_egressip_tests.yml:42) is the origin repo pattern. openshift-tests-private's Makefile doesn't use WHAT - it works because the variable is ignored and the default target runs, but the correct command is make build (matching the IR plugin).
3. Needs end-to-end verification
Before merging, this should be executed against a live environment to confirm the full flow works: clone, build, test filtering, execution, and result collection. Have you been able to run this successfully?
Everything else looks good - the allowlist covers the same test set as the IR source (with simplified regexes), the version/backend detection logic is solid, and skipping the copy step matches the IR plugin's approach for this repo.
Port EgressIP testing from Jenkins/infrared to shiftstack-qa. - Creates egressip_tests role that runs openshift-tests-private suite - Dynamically detects OCP version (4.12-4.22) and network backend (OpenShiftSDN/OVNKubernetes/Kuryr) - Filters tests using per-version, per-backend allowlist - Integrated into osp_verification.yaml for OSP candidate release validation Allowlist ported from rhos-infrared egressip-whitelist.yaml covering: - 4.12-4.14: OpenShiftSDN, OVNKubernetes, Kuryr support - 4.15+: OVNKubernetes only (SDN deprecated) Change-Id: I222491ea7ed254e12ea5935564c1ce026d9bc105 Signed-off-by: Daniel Lawton <dlawton@redhat.com>
- Add OCP version/network type discovery task - Fix HOME env variable access (use lookup instead of ansible_env) - Correct Go install task filename (install_go.yml) - Fix allowlist conversion (disable version-based filtering) - Add git clone force flag for idempotency Verified working on OCP 4.22.3 + OVNKubernetes. Change-Id: I562113de5fd0d1f24dcceb0d1f810eedf2fb1719
dlaw4608
commented
Jun 28, 2026
https://gitlab.cee.redhat.com/ci-framework/ci-framework-testproject/-/merge_requests/2345@imatza-rh & @tusharjadhav3302 , E2E test passed ready for rereview |
imatza-rh
commented
Jun 28, 2026
@eshulman2 , @tusharjadhav3302 , @ekuris-redhat lgtm. feel free to review/merge. |
ekuris-redhat
left a comment
There was a problem hiding this comment.
LTGM , passed the E2E verification.
Added EgressIP test role to shiftstack-qa
Migrate EgressIP testing from Jenkins/infrared to shiftstack-qa as part of
the effort to consolidate all OpenShift-on-OpenStack testing into a single
framework.
This PR adds a new egressip_tests stage role that:
openshift-tests-privatetest suiteThe allowlist structure (ported from
rhos-infrared/egressip-whitelist.yaml)supports OCP 4.12-4.22 with version and network backend specific test filtering.
Tests are filtered from thousands down to ~14-20 relevant EgressIP tests based
on the cluster configuration.
Integration:
Generated with the help of Claude Code sonnet 4.5