Uh oh!
There was an error while loading. Please reload this page.
Add OWNERS, CODEOWNERS, and ansible-lint GitHub Action for Prow onboarding - #18
Merged
Conversation
imatza-rh
marked this pull request as ready for review
June 29, 2026 14:42
Enable Prow-based PR review workflow for shiftstack-qa: - OWNERS and OWNERS_ALIASES for /lgtm and /approve commands - CODEOWNERS for automatic reviewer assignment - GitHub Action running pre-commit (ansible-lint) on PRs, matching gate.sh behavior Ref: OSPRH-32049 Change-Id: I7c580137f660b31a3e3f06b62d07b82838e9663c Signed-off-by: Itay Matza <imatza@redhat.com>
- Add changed_when: true to two tasks in get_openshift_release_binaries - Add set -o pipefail to shell tasks with pipes in run-performance-test - Replace ignore_errors with failed_when: false in DUT pod cleanup Ref: OSPRH-32049 Change-Id: I7320ee163f4a2811f7dd7d535424fabb2c2e694e Signed-off-by: Itay Matza <imatza@redhat.com>
imatza-rh
requested review from
dlaw4608, ekuris-redhat, gryf, mandre, stephenfin and winiciusallanJuly 1, 2026 20:34
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Rename shiftstack-approvers/reviewers to openstack-approvers/reviewers to match the naming convention used across all other shiftstack org repos (shiftstack-ci, gazelle, ci-configs, merge-bot, etc.). Add arxcruz (Arx Cruz) and kstrenkova (Katarina Strenkova) as approvers and reviewers. Assisted-By: Claude Code Change-Id: I9bb750cae1a5c8bfd6a16d321b87cab78d58078e Signed-off-by: Itay Matza <imatza@redhat.com>
ekuris-redhat
requested changes
Jul 2, 2026
ekuris-redhat
left a comment
Contributor
There was a problem hiding this comment.
Please hold this PR so we can add additional team member Winston Chen , I am waiting to get his github user name
ekuris-redhat
self-requested a review
July 2, 2026 08:04
Uh oh!
There was an error while loading. Please reload this page.
Assisted-By: Claude Code Change-Id: I9ff550279fd6c46a8daba860ae875288d2ff7ad4 Signed-off-by: Itay Matza <imatza@redhat.com>
imatza-rh
commented
Jul 2, 2026
ContributorAuthor
This PR is needed for OSPNW-1656 - happy to take any further additions in a follow-up PR. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable Prow-based PR review workflow (/lgtm, /approve, /hold) and add CI gate as a GitHub Action.
Changes
.github/workflows/ansible-lint.yml: GitHub Action runningpre-commit run --all-fileson PRs - same asgate.shchanged_when: trueto two tasks inget_openshift_release_binaries.ymlset -o pipefailto shell tasks with pipes inrun-performance-test.ymlignore_errorswithfailed_when: falsein DUT pod cleanup taskNext steps (separate PRs)
core-services/prow/02_config/shiftstack/shiftstack-qa/Ref: OSPRH-32049