Uh oh!
There was an error while loading. Please reload this page.
Update to Svelte 5 - #3144
Merged
Merged
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
RobbieTheWagner
marked this pull request as ready for review
March 25, 2025 13:44
| import ShepherdElement from './components/shepherd-element.svelte'; | ||
| import { type Tour } from './tour.ts'; | ||
| import type { ComputePositionConfig } from '@floating-ui/dom'; | ||
| import { createClassComponent } from 'svelte/legacy'; |
MemberAuthor
There was a problem hiding this comment.
@Rich-Harris is there a way to do this without the legacy stuff? We need to get a reference to an element, which does not seem to be possible in Svelte 5 unless the parent is also a Svelte component.
RobbieTheWagnerforce-pushed
the
svelte-5-building
branch
from
October 1, 2025 13:49
cb31337 to
99ccfe3CompareRobbieTheWagnerforce-pushed
the
svelte-5-building
branch
from
November 7, 2025 12:41
511029d to
5562727CompareUh oh!
There was an error while loading. Please reload this page.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an effort to reduce complexity we will just be shipping ESM going forward. A lot of libraries have chosen this path and we believe it is the correct way to go.