Uh oh!
There was an error while loading. Please reload this page.
Remove markers when tether is destroyed - #1051
Conversation
RobbieTheWagner
commented
Mar 27, 2022
@pieter-v thanks for the PR! Is there a specific problem leaving the markers around is causing for you? I think they are meant to stick around. |
pieter-v
commented
Mar 28, 2022
Indeed, we have a What is the use-case for keeping the markers after the tether is destroyed? |
RobbieTheWagner
commented
Apr 20, 2022
@pieter-v I was not involved in the implementation of this library, but I think the idea was if you wanted to show the Tether again, there would be less work to setup the markers and such? Perhaps I am wrong. |
pieter-v
commented
Apr 21, 2022
@rwwagner90 If you set up a tether again, new markers are created and the old ones are left dangling. So, I think it is safe to destroy the markers when the tether is destroyed. |
RobbieTheWagner
commented
Apr 28, 2022
@pieter-v gotcha, that makes sense! I am not sure why CI is not running on this PR. Could you please try creating a new PR? |
pieter-v
commented
Apr 29, 2022
Closed in favour of #1075 |
When a
tetheris created, a marker element is created and added both to. theelementand to thetarget.This pull request removes the markers when the
tetheris destroyed.