Skip to content

[SIG-55948] Plugin Actions Support: Added custom hook for action registration and triggering - #10

Merged
alisonjlai merged 8 commits into
plugin-actionsfrom
alison/SIG-54790
Jun 28, 2024
Merged

[SIG-55948] Plugin Actions Support: Added custom hook for action registration and triggering#10
alisonjlai merged 8 commits into
plugin-actionsfrom
alison/SIG-54790

Conversation

@alisonjlai

@alisonjlaialisonjlai commented Jun 25, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

Resolves [SIG-55948]

What is the purpose of this PR?

Added a new CustomPluginConfigOptions type.
Created useActionTrigger hook to register/unregister and trigger an action event.

Will be merged to plugin-actions branch for now until slate side is more ready.

@alisonjlaialisonjlai changed the title Plugin Actions Support: Added custom hook for action registration and triggering[SIG-55948] Plugin Actions Support: Added custom hook for action registration and triggeringJun 25, 2024
@alisonjlai
alisonjlai marked this pull request as ready for review June 25, 2024 23:48
Pearce-Ropion
Pearce-Ropion reviewed Jun 26, 2024
View reviewed changes

@Pearce-RopionPearce-Ropion left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of merging this to master, let's create a new branch called plugin-actions, and then switch the base of this PR to that branch. I'm hesitant about pushing code that only works behind a feature flag in the product to the plugin master branch. Once more of the slight side of things is done, we can merge the actions branch here into master.

Comment threadsrc/react/hooks.ts Outdated
Comment threadsrc/react/hooks.ts Outdated
@alisonjlai
alisonjlai changed the base branch from main to plugin-actionsJune 26, 2024 01:12
@alisonjlai

alisonjlai commented Jun 26, 2024

Copy link
Copy Markdown
ContributorAuthor

Instead of merging this to master, let's create a new branch called plugin-actions, and then switch the base of this PR to that branch. I'm hesitant about pushing code that only works behind a feature flag in the product to the plugin master branch. Once more of the slight side of things is done, we can merge the actions branch here into master.

Just pushed the changes and switched the base to plugin-actions!

peternandersson
peternandersson reviewed Jun 26, 2024
View reviewed changes
Comment threadsrc/client/initialize.ts Outdated
@alisonjlai
alisonjlai marked this pull request as draft June 27, 2024 21:56
@alisonjlai
alisonjlai marked this pull request as ready for review June 27, 2024 21:59
Pearce-Ropion
Pearce-Ropion reviewed Jun 27, 2024
View reviewed changes
Comment threadsrc/react/hooks.ts Outdated
Comment threadsrc/client/initialize.ts
peternandersson
peternandersson reviewed Jun 27, 2024
View reviewed changes
Comment threadsrc/client/initialize.ts
peternandersson
peternandersson approved these changes Jun 28, 2024
View reviewed changes

@peternanderssonpeternandersson left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment threadREADME.md
Pearce-Ropion
Pearce-Ropion requested changes Jun 28, 2024
View reviewed changes
Comment threadREADME.md Outdated
Comment threadREADME.md
Comment threadsrc/client/initialize.ts
Comment threadsrc/client/initialize.ts Outdated
@alisonjlai
alisonjlai merged commit 4c3ca62 into plugin-actionsJun 28, 2024
@alisonjlai
alisonjlai deleted the alison/SIG-54790 branch June 28, 2024 23:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pearce-RopionPearce-RopionPearce-Ropion approved these changes
@peternanderssonpeternanderssonpeternandersson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alisonjlai@Pearce-Ropion@peternandersson