Uh oh!
There was an error while loading. Please reload this page.
Conversation
NUnit Tests 1 files ± 0 1 suites ±0 8m 27s ⏱️ - 2m 57s Results for commit 4c544b0. ± Comparison against base commit ca025cd. This pull request removes 6 and adds 24 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@## main #1094 +/- ##
==========================================
+ Coverage 38.31% 38.34% +0.02%
==========================================
Files 1507 1507 Lines 350524 350580 +56 Branches 40288 40293 +5 ==========================================
+ Hits 134302 134426 +124 + Misses 186990 186925 -65 + Partials 29232 29229 -3
🚀 New features to boost your workflow:
|
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
Ask Claude to find a different set of words for 'gesture' that fits our identity as a desktop app and apply it throughout this PR.
@jasonleenaylor reviewed all commit messages and made 1 comment.
Reviewable status: 0 of 11 files reviewed, all discussions resolved.
The Avalonia detail view now answers a right-click and the keyboard menu key on every row, showing the two menus its layout defines and keeping them distinct: - A row's label cell, and a section header, answer right-click with the slice menu. The "..." field-options button still opens the row's own menu or its hotlinks, by mouse or keyboard. - A row's value box answers right-click and the keyboard menu key with the in-string contextMenu= menu, including a right-click on the writing-system abbreviation gutter. - The in-string menu now opens on right-button release rather than press, a side effect of raising it from ContextRequested. - ComposeSliceMenuIds and ComposeInStringMenuIds keep the two compositions apart: the slice menu is the row's menu= plus exactly one shared trailing group (the object group alone when a row binds no menu=), while the value menu is the contextMenu= binding alone. Section hotlinks stay on their own affordance. - XCoreMenuBridge splices inline choice lists, so the Writing Systems entries appear instead of being dropped as an invisible submenu. - A menu opened without a pointer position anchors under the field it came from rather than at the last pointer position, which acceptance test 5 specifies; a right-click still opens at the pointer. DetailMenuRequest carries the anchor control and OpenAtPointer, and the fallback adapter menu derives its screen point when it runs. The tests drive the real headless input pipeline -- right-button release and the menu key -- so the wiring, the anchoring, and both compositions are covered. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
mark-sil
commented
Aug 20, 2026
mark-sil
left a comment
ContributorAuthor
There was a problem hiding this comment.
The name changes have been pushed and the commit/PR message is fixed.
@mark-sil made 1 comment.
Reviewable status: 0 of 11 files reviewed, all discussions resolved (waiting on jasonleenaylor).
jasonleenaylor
approved these changes
Aug 20, 2026
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
@jasonleenaylor reviewed 10 files and all commit messages, and made 1 comment.
Reviewable status: 10 of 11 files reviewed, all discussions resolved.
Uh oh!
There was an error while loading. Please reload this page.
thejambi pushed a commit
that referenced
this pull request
Aug 25, 2026
…#1094) The Avalonia detail view now answers a right-click and the keyboard menu key on every row, showing the two menus its layout defines and keeping them distinct: - A row's label cell, and a section header, answer right-click with the slice menu. The "..." field-options button still opens the row's own menu or its hotlinks, by mouse or keyboard. - A row's value box answers right-click and the keyboard menu key with the in-string contextMenu= menu, including a right-click on the writing-system abbreviation gutter. - The in-string menu now opens on right-button release rather than press, a side effect of raising it from ContextRequested. - ComposeSliceMenuIds and ComposeInStringMenuIds keep the two compositions apart: the slice menu is the row's menu= plus exactly one shared trailing group (the object group alone when a row binds no menu=), while the value menu is the contextMenu= binding alone. Section hotlinks stay on their own affordance. - XCoreMenuBridge splices inline choice lists, so the Writing Systems entries appear instead of being dropped as an invisible submenu. - A menu opened without a pointer position anchors under the field it came from rather than at the last pointer position, which acceptance test 5 specifies; a right-click still opens at the pointer. DetailMenuRequest carries the anchor control and OpenAtPointer, and the fallback adapter menu derives its screen point when it runs. The tests drive the real headless input pipeline -- right-button release and the menu key -- so the wiring, the anchoring, and both compositions are covered. Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Avalonia detail view now answers a right-click and the keyboard menu key on every row, showing the two menus its layout defines and keeping them distinct:
This change is