Uh oh!
There was an error while loading. Please reload this page.
LT-22691: Publish writing system under cursor - #1095
Merged
Conversation
The detail editor focus hook now also publishes the window-scoped WritingSystemUnderCursorChanged event, so the toolbar writing-system combo tracks the cursor while the Avalonia detail view is focused. Notes: - This adds the first Avalonia-to-WinForms state channel rather than replacing an adapter route. - The view publishes an event instead of writing the property itself so the relevant code stays quarantined in the one listener that already owns that combo. The view stays ignorant of its consumers, and a replacement toolbar later subscribes to the same event without touching the view. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
codecov-commenter
commented
Aug 20, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #1095 +/- ##
==========================================
+ Coverage 38.31% 38.33% +0.01%
==========================================
Files 1507 1507 Lines 350524 350554 +30 Branches 40288 40291 +3 ==========================================
+ Hits 134302 134370 +68 + Misses 186990 186954 -36 + Partials 29232 29230 -2
🚀 New features to boost your workflow:
|
jasonleenaylor
approved these changes
Aug 20, 2026
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
@jasonleenaylor reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on mark-sil).
Uh oh!
There was an error while loading. Please reload this page.
thejambi pushed a commit
that referenced
this pull request
Aug 25, 2026
The detail editor focus hook now also publishes the window-scoped WritingSystemUnderCursorChanged event, so the toolbar writing-system combo tracks the cursor while the Avalonia detail view is focused. Notes: - This adds the first Avalonia-to-WinForms state channel rather than replacing an adapter route. - The view publishes an event instead of writing the property itself so the relevant code stays quarantined in the one listener that already owns that combo. The view stays ignorant of its consumers, and a replacement toolbar later subscribes to the same event without touching the view. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The detail editor focus hook now also publishes the window-scoped WritingSystemUnderCursorChanged event, so the toolbar writing-system combo tracks the cursor while the Avalonia detail view is focused.
Notes:
This change is