Uh oh!
There was an error while loading. Please reload this page.
Cleanup comments - #1120
Merged
Merged
Conversation
There is no "gear-menu" in the product, so eight comments change the wording to "menu-button", which also stops AI from copying "gear-menu" into new comments. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
codecov-commenter
commented
Sep 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@## main #1120 +/- ##
==========================================
- Coverage 38.55% 38.55% -0.01%
==========================================
Files 1513 1513 Lines 350968 350968 Branches 40345 40345 ==========================================
- Hits 135322 135308 -14 - Misses 186429 186444 +15 + Partials 29217 29216 -1
🚀 New features to boost your workflow:
|
papeh
approved these changes
Sep 2, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eight comments across six files described the detail row's field menu as a "gear menu". There is no gear anywhere: it is a blue down-arrow in the legacy view and a three-dot button in Avalonia. They now say "menu-button", the term already used in LT-17670 and LT-19150 — which also stops the wrong word being copied into new comments.
Comments only. No executable code changed, so the build is the gate here; it validates the
<see cref>references in the doc comments, and there is nothing for tests to exercise.The diff is a little larger than eight word swaps. "menu-button" is two characters longer than "gear-menu", which pushed five lines past the width limit and tripped the comment-hygiene auto-rewrap, stranding single words ("composed", "view", "restores", "layout's", "change") on their own lines. Those blocks are hand-rewrapped so the prose reads normally and stays under the limit.
One further occurrence, the log message in
RecordEditView.Avalonia.cs, is deliberately absent: it is already fixed in #1119, and touching it here would conflict.This change is