Retire Linux-era view shims by johnml1135 · Pull Request #906 · sillsdev/FieldWorks

johnml1135 · 2026-05-21T00:17:16Z

Summary

remove the retired Linux-era managed Views shims ViewInputManager and ManagedVwWindow, including their solution and build wiring
keep the Windows-native RootSite path in place by using VwTextStore/IViewInputMgr and HWND client-rectangle geometry while removing stale IVwWindow/VwWindow interop exposure
update reg-free manifest inputs, architecture/OpenSpec docs, and task tracking for the shim retirement

Validation

./build.ps1
./test.ps1 -SkipManaged -TestProject TestViews
./test.ps1 -TestProject FwBuildTasksTests -TestFilter "FullyQualifiedName~RegFreeCreator"
./test.ps1 -TestProject SimpleRootSiteTests
CI: Whitespace check
Manual smoke in rebuilt FieldWorks app covering lexical edit view typing, keyboard switching, IME/composition, selection/PageUp/PageDown, and launch/manifest sanity

This change is

Copilot

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR retires legacy Linux/Mono-era managed Views shims (ViewInputManager, ManagedVwWindow) and updates code/docs/build plumbing to rely solely on the Windows-native Views input and geometry paths.

Changes:

Removed managed shim projects/sources and related solution/build/reg-free manifest wiring.
Simplified native Views codepaths to always use Windows-native VwTextStore (input) and GetClientRect (geometry), eliminating COM activation branches.
Updated OpenSpec architecture docs/specs and change-tracking artifacts to reflect the shim retirement.

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
openspec/specs/architecture/ui-framework/views-rendering.md	Updates architecture diagram text to reflect Windows-native input/geometry and shim retirement.
openspec/specs/architecture/interop/native-boundary.md	Updates interop boundary documentation to remove `ManagedVwWindow` as an active boundary.
openspec/specs/architecture/interop/com-contracts.md	Notes retired shims in COM contracts documentation.
openspec/changes/retire-linux-era-view-shims/**	Adds proposal/design/research/tasks and requirements specs for shim retirement and validation.
Src/views/VwRootBox.cpp	Removes non-Windows COM activation branch for `ViewInputManager`.
Src/views/VwSelection.cpp	Removes non-Windows `IVwWindow` wrapper path; always uses `GetClientRect`.
Src/views/VwTextStore.cpp	Removes non-Windows conditional around `ClientToScreen` / TSF-related behavior.
Src/views/Views.idh	Removes `IVwWindow`/`VwWindow` interface+coclass; adjusts `IViewInputMgr` comment.
Src/views/Views_GUIDs.cpp	Removes GUID exports for `IVwWindow`/`VwWindow`.
Src/Common/SimpleRootSite/ViewInputManager.cs	Deletes managed `ViewInputManager` shim.
Src/ManagedVwWindow/**	Deletes managed `ManagedVwWindow` project and its tests.
Build/RegFree.targets	Removes `ManagedVwWindow.dll` from managed COM manifest inputs.
Src/Common/FieldWorks/BuildInclude.targets	Removes `ManagedVwWindow.dll` from FieldWorks manifest inputs.
Build/mkall.targets	Removes excluded CLSIDs for the retired managed shims.
Build/Src/FwBuildTasks/CollectTargets.cs	Removes special-case Unix-only condition for `ManagedVwWindow` project.
FieldWorks.sln	Removes `ManagedVwWindow` projects from the solution.
.github/src-catalog.md	Removes catalog entry for `ManagedVwWindow`.

github-actions · 2026-05-21T00:27:14Z

NUnit Tests

1 files ±0 1 suites ±0 9m 25s ⏱️ - 1m 43s
4 203 tests - 2 4 132 ✅ - 2 71 💤 ±0 0 ❌ ±0
4 212 runs - 2 4 141 ✅ - 2 71 💤 ±0 0 ❌ ±0

Results for commit 32dbddd. ± Comparison against base commit b0bf8a8.

This pull request removes 2 tests.

SIL.FieldWorks.Language.ManagedVwWindowTests ‑ NotSettingWindowTest
SIL.FieldWorks.Language.ManagedVwWindowTests ‑ SimpleWindowTest

jasonleenaylor

@jasonleenaylor reviewed 20 files and all commit messages, and made 1 comment.
Reviewable status: 20 of 28 files reviewed, 4 unresolved discussions (waiting on johnml1135).

Add missing manifest files to RescuePatching target The base build 1437 (from release/9.3.9) still contains ManagedVwWindow.manifest and SimpleRootSite.manifest, which were removed on main by #906. The existing fix (#909) handled .dll, .dll.config, and .pdb but missed the two .manifest files, causing PYRO0305 errors during patch builds. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

- VersionInfoProvider: copyright year no longer freezes at whatever year the constant was last edited, ApplicationVersion resolves from the correct assembly instead of always falling back to the entry assembly, and MajorVersion/ParseInformationalVersion index defensively instead of assuming a fixed part count. Covered by new VersionInfoProviderTests.cs. - RegFree.targets: removes a dangling ManagedVwWindow.dll entry; the project was already retired in #904/#906, so the entry pointed at nothing. - opsx-*.prompt.md: replace inlined instructions with delegation to the existing .claude/skills/openspec-*/SKILL.md files, per this repo's skills-over-inline-prompts convention. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

…d files ManagedVwWindow.dll was retired with the Linux-era view shims (#906). The RegFree.targets fallback entry was removed earlier in this PR, but BuildInclude.targets pre-populates ManagedComAssemblies explicitly for FieldWorks.exe (bypassing that fallback), so the "Could not find file" warning kept firing for the main product. Also drops the matching stale CLSID exclusion in mkall.targets. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

ManagedVwWindow.dll was retired with the Linux-era view shims (#906). The RegFree.targets fallback entry was removed earlier in this PR, but BuildInclude.targets pre-populates ManagedComAssemblies explicitly for FieldWorks.exe (bypassing that fallback), so the "Could not find file" warning kept firing for the main product. Also drops the matching stale CLSID exclusion in mkall.targets. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Both are fully implemented and merged (PR #870, PR #906), unrelated to the Avalonia migration spine; archiving keeps openspec/changes/ scoped to work still in flight. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

- VersionInfoProvider: copyright year no longer freezes at whatever year the constant was last edited, ApplicationVersion resolves from the correct assembly instead of always falling back to the entry assembly, and MajorVersion/ParseInformationalVersion index defensively instead of assuming a fixed part count. Covered by new VersionInfoProviderTests.cs. - RegFree.targets: removes a dangling ManagedVwWindow.dll entry; the project was already retired in #904/#906, so the entry pointed at nothing. - opsx-*.prompt.md: replace inlined instructions with delegation to the existing .claude/skills/openspec-*/SKILL.md files, per this repo's skills-over-inline-prompts convention. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

ManagedVwWindow.dll was retired with the Linux-era view shims (#906). The RegFree.targets fallback entry was removed earlier in this PR, but BuildInclude.targets pre-populates ManagedComAssemblies explicitly for FieldWorks.exe (bypassing that fallback), so the "Could not find file" warning kept firing for the main product. Also drops the matching stale CLSID exclusion in mkall.targets. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

- VersionInfoProvider: copyright year no longer freezes at whatever year the constant was last edited, ApplicationVersion resolves from the correct assembly instead of always falling back to the entry assembly, and MajorVersion/ParseInformationalVersion index defensively instead of assuming a fixed part count. Covered by new VersionInfoProviderTests.cs. - RegFree.targets: removes a dangling ManagedVwWindow.dll entry; the project was already retired in #904/#906, so the entry pointed at nothing. - opsx-*.prompt.md: replace inlined instructions with delegation to the existing .claude/skills/openspec-*/SKILL.md files, per this repo's skills-over-inline-prompts convention. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

ManagedVwWindow.dll was retired with the Linux-era view shims (#906). The RegFree.targets fallback entry was removed earlier in this PR, but BuildInclude.targets pre-populates ManagedComAssemblies explicitly for FieldWorks.exe (bypassing that fallback), so the "Could not find file" warning kept firing for the main product. Also drops the matching stale CLSID exclusion in mkall.targets. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

- VersionInfoProvider: copyright year no longer freezes at whatever year the constant was last edited, ApplicationVersion resolves from the correct assembly instead of always falling back to the entry assembly, and MajorVersion/ParseInformationalVersion index defensively instead of assuming a fixed part count. Covered by new VersionInfoProviderTests.cs. - RegFree.targets: removes a dangling ManagedVwWindow.dll entry; the project was already retired in #904/#906, so the entry pointed at nothing. - opsx-*.prompt.md: replace inlined instructions with delegation to the existing .claude/skills/openspec-*/SKILL.md files, per this repo's skills-over-inline-prompts convention. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

ManagedVwWindow.dll was retired with the Linux-era view shims (#906). The RegFree.targets fallback entry was removed earlier in this PR, but BuildInclude.targets pre-populates ManagedComAssemblies explicitly for FieldWorks.exe (bypassing that fallback), so the "Could not find file" warning kept firing for the main product. Also drops the matching stale CLSID exclusion in mkall.targets. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

…, thin opsx prompts (#978) * chore: small fixes pulled off from PR #964 - VersionInfoProvider: copyright year no longer freezes at whatever year the constant was last edited, ApplicationVersion resolves from the correct assembly instead of always falling back to the entry assembly, and MajorVersion/ParseInformationalVersion index defensively instead of assuming a fixed part count. Covered by new VersionInfoProviderTests.cs. - RegFree.targets: removes a dangling ManagedVwWindow.dll entry; the project was already retired in #904/#906, so the entry pointed at nothing. - opsx-*.prompt.md: replace inlined instructions with delegation to the existing .claude/skills/openspec-*/SKILL.md files, per this repo's skills-over-inline-prompts convention. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Drop stale ManagedVwWindow.dll references from RegFree build files ManagedVwWindow.dll was retired with the Linux-era view shims (#906). The RegFree.targets fallback entry was removed earlier in this PR, but BuildInclude.targets pre-populates ManagedComAssemblies explicitly for FieldWorks.exe (bypassing that fallback), so the "Could not find file" warning kept firing for the main product. Also drops the matching stale CLSID exclusion in mkall.targets. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * style: use ASCII punctuation in new prompt/doc/test prose This branch's new content used em-dashes and a Unicode "<=" sign in a few places (opsx-explore.prompt.md, opsx-onboard.prompt.md, AGENTS.md, VersionInfoProviderTests.cs), which render poorly in some git tooling. Switch them to the ASCII "--" and "<=" forms the rest of the repo's prose and comments already use. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Address review comments on VersionInfoProvider Shorten the comment blocks flagged over the 200-character cap (MajorVersion 241, CopyrightString 214, ApplicationVersion 204) and rewrite the four that narrated repo history, named callers, or restated the member name. Guard the one line in this file that could actually throw: Convert.ToInt32(versionParts[1]) raised FormatException on a non-numeric token, out of a property getter the splash screen and About box read. int.TryParse leaves date at 0, which the existing date > 0 check already treats as no date, so the fallback path is unchanged. This matches BaseBuildNumber, which already uses int.TryParse in the same file. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011arsbDno5H5y2pLGqGgb9L --------- Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>

johnml1135 added 3 commits May 20, 2026 18:22

docs: add linux-era view shim retirement plan
3e19715

Initial implementation
ba24829

Manually tested lexical edit view and interliner
32dbddd

CopilotAI review requested due to automatic review settings May 21, 2026 00:17

CopilotAI reviewed May 21, 2026
View reviewed changes

Comment threadopenspec/specs/architecture/ui-framework/views-rendering.md
Comment threadopenspec/specs/architecture/interop/native-boundary.md
Comment threadSrc/views/VwSelection.cpp
Comment threadSrc/views/VwTextStore.cpp

jasonleenaylor approved these changes May 21, 2026
View reviewed changes

johnml1135 merged commit 8e99077 into mainMay 22, 2026
9 of 12 checks passed

johnml1135 deleted the retire-linux-era-view-shims branch May 22, 2026 11:56

jasonleenaylor mentioned this pull request Jun 4, 2026
Add missing manifest files to RescuePatching #929
Merged
1 task

This was referenced Jul 1, 2026
chore: fix VersionInfoProvider bugs, drop stale RegFree.targets entry, thin opsx prompts #978
Merged
Build: drop retired ManagedVwWindow.dll from RegFree managed COM list #989
Closed

Navigation Menu

Uh oh!

Uh oh!

Retire Linux-era view shims - #906

Retire Linux-era view shims#906
johnml1135 merged 3 commits into
mainfrom
retire-linux-era-view-shims

johnml1135 commented May 21, 2026•
edited by jasonleenaylor
Loading

Uh oh!

CopilotAI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented May 21, 2026

Uh oh!

jasonleenaylor left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Uh oh!

Conversation

johnml1135 commented May 21, 2026• edited by jasonleenaylor Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actionsBot commented May 21, 2026

NUnit Tests

Uh oh!

jasonleenaylor left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

johnml1135 commented May 21, 2026•
edited by jasonleenaylor
Loading