Skip to content

Make example project slightly more realistic - #2268

Merged
myieye merged 1 commit into
developfrom
make-example-project-a-bit-better
May 15, 2026
Merged

Make example project slightly more realistic#2268
myieye merged 1 commit into
developfrom
make-example-project-a-bit-better

Conversation

@myieye

@myieyemyieye commented May 15, 2026

Copy link
Copy Markdown
Collaborator

The example project was overly bad 😆.
English was the only populated vernacular and analysis WS.
And it makes more sense to have vernacular audio than analysis audio.
This makes things just slightly less absurd and enriches with more entries, IPA, some complex-forms, PoS assignments etc.
It's still very rudimentary.

image

@coderabbitai

coderabbitaiBot commented May 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Refactors example project seeding by extracting the in-file SampleProjectData method from CrdtProjectsService into a new ExampleProjectData.Seed module with orchestrated helpers, while centralizing predefined Guid constants for complex forms and parts of speech in PreDefinedData.

Changes

Example Project Seeding Refactor

Layer / File(s)Summary
Predefined seeding data contracts
backend/FwLite/LcmCrdt/Objects/PreDefinedData.cs
Public Guid constants for complex form types (CompoundComplexFormTypeId, UnspecifiedComplexFormTypeId) and parts of speech (Noun, Verb, Adjective, Adverb) replace inline literals. Predefined creation methods reference these constants. Vernacular writing systems now include de-Zxxx-x-audio; Analysis writing systems reduced to en only.
Example data seeding implementation
backend/FwLite/LcmCrdt/ExampleProjectData.cs
New ExampleProjectData.Seed entry point orchestrates three sequential helpers: CreateWritingSystems (German/IPA/English/French variants), CreateFruitEntries (Apfel, Banane, Orange, Traube, Beere with multilingual lexemes, glosses, definitions, example sentences), and CreateBerryComplexForms (Erdbeere, Heidelbeere as complex forms with base entry links and type registration).
CrdtProjectsService integration
backend/FwLite/LcmCrdt/CrdtProjectsService.cs
CreateExampleProject now passes ExampleProjectData.Seed to the project creation pipeline instead of the removed SampleProjectData method. The 156-line SampleProjectData method is deleted from the service.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

Suggested labels

💻 FW Lite

Poem

🐰 Hopping through the data flows,
Berries sprout where seeding goes,
Old methods fade to history,
New examples bloom with glee—
German fruit and complex forms,
Constants tidy up the norms! 🍓✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check nameStatusExplanationResolution
Docstring Coverage⚠️ WarningDocstring coverage is 10.00% which is insufficient. The required threshold is 80.00%.Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Title check✅ PassedThe title accurately reflects the main change: enriching the example project with more realistic data including additional entries, IPA, complex forms, and parts-of-speech assignments.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
Description check✅ PassedThe pull request description directly addresses the changes made: improving the example project by enriching it with more entries, IPA, complex forms, and PoS assignments while fixing the writing system configuration issues.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch make-example-project-a-bit-better

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actionsgithub-actionsBot added the 💻 FW Lite issues related to the fw lite application, not miniLcm or crdt related label May 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

UI unit Tests

1 files ±0 59 suites ±0 29s ⏱️ -1s
176 tests ±0 176 ✅ ±0 0 💤 ±0 0 ❌ ±0 
245 runs ±0 245 ✅ ±0 0 💤 ±0 0 ❌ ±0 

Results for commit 0d6775b. ± Comparison against base commit 9d47e7e.

@argos-ci

argos-ciBot commented May 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Argos notifications ↗︎

BuildStatusDetailsUpdated (UTC)
default (Inspect)✅ No changes detected-May 15, 2026, 1:42 PM

@myieye
myieye merged commit dfcaf0d into developMay 15, 2026
19 checks passed
@myieye
myieye deleted the make-example-project-a-bit-better branch May 15, 2026 14:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

💻 FW Liteissues related to the fw lite application, not miniLcm or crdt related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@myieye