Uh oh!
There was an error while loading. Please reload this page.
Add net8.0 target to SIL.LCModel, Utils, and FixData - #385
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
jasonleenaylor
approved these changes
Jul 2, 2026
jasonleenaylor
left a comment
Contributor
There was a problem hiding this comment.
@jasonleenaylor reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on hahn-kev).
Uh oh!
There was an error while loading. Please reload this page.
jasonleenaylor added a commit
that referenced
this pull request
Aug 28, 2026
The removed wrapper scripts called msbuild without /m, so they were implicitly serial. dotnet build is parallel by default, and on a tree with no generated sources yet the GenerateModel and GenerateKernelCs targets can run concurrently against the same non-per-framework outputs, then fail as LcmGenerate or IdlImp "returned false but did not log an error". The failure is intermittent, so the error is easy to misread as a broken change. README.md and AGENTS.md now name -m:1 for a cold-start build. Correct the Windows prerequisite to Visual Studio 2022. net8.0 targets were added in #385 and VS 2019 cannot build them. The C++ build tools are needed for any Windows build rather than only for building in the IDE, because code generation preprocesses the IDL with cl.exe. Drop the AGENTS.md root-file inventory, which duplicated the repository root and went stale with this change, and ask anyone whose run contradicts the file to report it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why we weren't targeting net8 on only core, but now we're targeting it on the other projects as well.
This change is