Skip to content

Update machine library to 1.6.3 - #177

Merged
Enkidu93 merged 2 commits into
mainfrom
v1.6.3
May 16, 2025
Merged

Update machine library to 1.6.3#177
Enkidu93 merged 2 commits into
mainfrom
v1.6.3

Conversation

@Enkidu93

@Enkidu93Enkidu93 commented May 15, 2025

Copy link
Copy Markdown
Collaborator

This change is Reviewable

@codecov-commenter

codecov-commenter commented May 15, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.87%. Comparing base (f533cfb) to head (97927ad).

Additional details and impacted files
@@ Coverage Diff @@## main #177 +/- ##
=======================================
Coverage 88.87% 88.87% =======================================
Files 282 282 Lines 16951 16951 =======================================
Hits 15065 15065 Misses 1886 1886 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ddaspitddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)


pyproject.toml line 35 at r1 (raw file):

[tool.poetry]
name = "sil-machine"version = "1.6.3"

It feels like there are enough changes to warrant a minor version bump, i.e. 1.7.0.

@Enkidu93Enkidu93 left a comment

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @ddaspit)


pyproject.toml line 35 at r1 (raw file):

Previously, ddaspit (Damien Daspit) wrote…

It feels like there are enough changes to warrant a minor version bump, i.e. 1.7.0.

Done. Except now the branch name is killing me 😆 😵‍💫

@ddaspitddaspit left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)


pyproject.toml line 35 at r1 (raw file):

Previously, Enkidu93 (Eli C. Lowry) wrote…

Done. Except now the branch name is killing me 😆 😵‍💫

I know it's hard, but you'll survive. 🤣

@Enkidu93
Enkidu93 merged commit 0ff0f8d into mainMay 16, 2025
@Enkidu93
Enkidu93 deleted the v1.6.3 branch May 16, 2025 14:51
benjaminking pushed a commit that referenced this pull request Jun 6, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Enkidu93@codecov-commenter@ddaspit