Skip to content

Add support for transductive alignment models - #327

Merged
ddaspit merged 4 commits into
mainfrom
transductive-model
Jul 15, 2026
Merged

Add support for transductive alignment models#327
ddaspit merged 4 commits into
mainfrom
transductive-model

Conversation

@ddaspit

@ddaspitddaspit commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

This change is Reviewable

@codecov-commenter

codecov-commenter commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.18321% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.99%. Comparing base (3632b96) to head (2a0882a).

Files with missing linesPatch %Lines
machine/translation/corpus_ops.py85.71%4 Missing ⚠️
...tion/thot/thot_symmetrized_word_alignment_model.py94.44%1 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@## main #327 +/- ##
==========================================
+ Coverage 91.78% 91.99% +0.20% 
==========================================
Files 362 364 +2 Lines 23735 23851 +116 ==========================================
+ Hits 21786 21942 +156 + Misses 1949 1909 -40 

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Enkidu93Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 reviewed 12 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on ddaspit).

ddaspitand others added 4 commits July 15, 2026 17:19
The Poetry 2.x relock tagged transformers/datasets (declared as both main
deps and extras) with `markers = extra == "huggingface"`, so CI's plain
`poetry install` no longer installed them and pyright failed on missing
imports. Relock with Poetry 1.8.2 (matching the repo's lock format) so the
sil-thot 3.5.1 bump is minimal and those packages stay unconditional.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@ddaspit
ddaspitforce-pushed the transductive-model branch from 3cd58ae to 2a0882aCompareJuly 15, 2026 21:20
@ddaspit
ddaspit merged commit 4a94d46 into mainJul 15, 2026
13 of 14 checks passed
@ddaspit
ddaspit deleted the transductive-model branch July 15, 2026 21:29
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ddaspit@codecov-commenter@Enkidu93