Treat upstream fetch failure as drift and refresh sync tooling - #155
Conversation
hasDifferences now returns true when missingUpstream > 0, the fingerprint includes UPSTREAM_ERROR classes so issue dedup works for fetch-failure drift, and the summary renders a Missing Upstream section listing each affected class and error. Previously a dead upstream fetch path reported all-clear, which is what blinded the daily tracker after the upstream incubator move (see #145). Verify: mvnd -pl json-java21-api-tracker -am clean test (14 tracker tests green, 3 new); full reactor clean verify = 1679 tests 0 skipped; ci.yml exp_tests 1676 -> 1679.
RefreshFromUpstream.java now fetches the impl package from src/jdk.incubator.json/.../jdk/incubator/json/impl/, snapshots it under upstream/jdk.incubator.json.impl and skips the local-only LazyConstant polyfill. transform_upstream.py maps the upstream incubator packages to our jdk.incubator.* packages, drops the obsolete StableValue skip and reminds the operator to re-append the Utils.powExact polyfill. Transform regexes dry-run verified against fetched upstream sources. Verify: python3 dry-run of transform() on JsonStringImpl.java (5/5 mapping checks pass); no source-tree changes made by the dry run.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1d31a918dd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| SRC = 'updates/2025-09-04/upstream/jdk.internal.util.json' | ||
| # Refreshed 2026-08-30 for the upstream jdk.incubator.json module layout (issue #154). | ||
| # Scope: impl files fetched into the snapshot dir (see RefreshFromUpstream.java). | ||
| # Public API files follow the manual process in json-java21/AGENTS.md. |
There was a problem hiding this comment.
When an operator follows this new pointer for the public API half of a sync, json-java21/AGENTS.md still directs them to the retired src/java.base/share/classes paths and the old java.util.json/jdk.internal.util.json packages, so the refreshed implementation tooling cannot lead to a complete upstream sync. Update those agent instructions to the incubator module layout as part of this change.
AGENTS.md reference: AGENTS.md:L23-L29
Useful? React with 👍 / 👎.
|
|
||
| @Nested | ||
| @DisplayName("Drift Detection Gates") | ||
| class DriftDetectionGateTests { |
There was a problem hiding this comment.
This newly added JUnit test container does not extend a logging-configuration helper and instead repeats ad hoc global logging setup inside each method. Put the group under a shared logging-config base so Maven-selected JUL levels remain centralized and consistent with the repository's non-negotiable test harness convention.
AGENTS.md reference: AGENTS.md:L47-L48
Useful? React with 👍 / 👎.
Closes #153
Closes #154
What
ApiTracker.hasDifferencesnow treats upstream fetch/parse failures as drift (missingUpstream > 0), the fingerprint includesUPSTREAM_ERRORclasses (stable + distinct per class set for issue dedup), and the summary renders a "Missing Upstream" section listing each affected class and error. This closes the failure mode that silently blinded the daily tracker Feb–Apr 2026.RefreshFromUpstream.javaandtransform_upstream.pyretargeted from the retiredjava.baselayout to thesrc/jdk.incubator.jsonmodule (fetch paths, snapshot dir, package mappings, skip-list cleanup). Transform regexes dry-run verified against fetched upstream sources (5/5 mapping checks).Tests
clean verify: 1679 tests, 0 failures, 0 errors, 0 skipped;ci.ymlexp_tests1676 → 1679No release: no version bump, no tag.