v12 by adriaandotcom · Pull Request #40 · simpleanalytics/scripts

adriaandotcom · 2023-05-12T12:48:34Z

Fix invalid bot detection with window.phantom.solana
Expose sa_pageview function always, to use with ignore-pages
Only compare non-www with non-www domains for uniques #41
Check for Cloudflare under attack param (Firewall team explains the param)
Illegal invocation with sendBeacon and URL has an error #42
When merging, make sure to update beta.js as well or inform customer (team 13489e0b-295c-476b-b955-46389fe10895)

It seems Solana from Phantom has this namespace for their browser extension. I added a check for prevent them being detected as bots.

Fix problem with solana extension

…ts, run prettier

…ith-jsdom-and-mocha Add unit tests using jsdom

Save local changes v12-b

…le [no ci] Add AGENTS instructions

…trategy-with-abstractions Add modular tests and helper utilities

…dling-in-sa_pageview Handle manual pageview query parameters

…etadata-collector Add test for metadata collector attribute

…auto-events [no ci] Add auto-events unit tests

…auto-events Add tel link tracking

cursor · 2025-07-29T13:13:25Z

🚨 Bugbot Trial Expired

Your Bugbot trial has expired. Please purchase a license in the Cursor dashboard to continue using Bugbot.

…egex-case-insensitive Fix allowParams case sensitivity

Resolve PR #40 conflicts while retaining the v12 dist artifacts. Keep main's BrowserStack workflow and nested-link click handling, and combine the test scripts from both branches.

ironbrands16and others added 21 commits May 11, 2023 18:39

Fix problem with solana extension
4e33371
It seems Solana from Phantom has this namespace for their browser extension. I added a check for prevent them being detected as bots.

Move from _phantom to phantom
38373b8

Merge pull request#39from ironbrands16/patch-1
ea0cd3d
Fix problem with solana extension

Run prettier via GitHub Action
f79ba5d

Fix bug in checking phantom.solana
3d7ccb5

Always expose sa_pageview
65a6c3a

Check for Cloudflare under attack mode param
a914c9a

Run prettier via GitHub Action
de31383

Test for all Cloudflare params
4924174

Clean subdomain hostname, fix auto events for links with child elemen…
23e043d
…ts, run prettier

Add acron and remove trailing comma
dc1a3ef

Run prettier via GitHub Action
6e7ce19

Save local changes [no ci]
e717409

Add jsdom unit tests
8845936

Fix default test without Browserstack
46992f6

Add unit test to job
5dad1ea

Make sure all node js version are the same
770470a

Merge pull request#63from simpleanalytics/codex/set-up-unit-tests-w…
cda1d7d
…ith-jsdom-and-mocha Add unit tests using jsdom

Merge branch 'v12' into v12-b
3fb3495

Allow overwriting referrer
065dbb1

Merge pull request#62from simpleanalytics/v12-b
ae84e8d
Save local changes v12-b

adriaandotcom mentioned this pull request May 29, 2025
Add referrer overwriting #54
Closed

adriaandotcomand others added 8 commits May 29, 2025 16:02

Rename testing file
e1702cf

Run prettier in dry mode [no ci]
779661a

Add AGENTS guidance
dc35828

Improve AGENTS.md
f99b45f

Add .cursorrules [no ci]
fbdd6ee

Merge pull request#64from simpleanalytics/codex/create-agents.md-fi…
fb045ce
…le [no ci] Add AGENTS instructions

Add modular unit tests and helpers
6bbf49a

Merge pull request#65from simpleanalytics/codex/plan-unit-testing-s…
d16c953
…trategy-with-abstractions Add modular tests and helper utilities

Merge branch 'v12' into codex/fix-query-param-handling-in-sa_pageview
984f634

This comment was marked as outdated.
Sign in to view

Merge pull request#74from simpleanalytics/codex/fix-query-param-han…
2bfd05c
…dling-in-sa_pageview Handle manual pageview query parameters

This comment was marked as outdated.
Sign in to view

adriaandotcomand others added 4 commits June 13, 2025 16:10

test: add metadata collector attr test
8ed3786

Merge branch 'v12' into codex/add-test-for-data-metadata-collector
28bf151

Merge pull request#75from simpleanalytics/codex/add-test-for-data-m…
e1b021e
…etadata-collector Add test for metadata collector attribute

Run npm run build
571b372

This comment was marked as outdated.
Sign in to view

adriaandotcomand others added 7 commits June 14, 2025 00:56

Add tel link tracking to auto events
c938f2f

Add unit tests for auto-events
67edab1

Warn when metadata collector function is not found
defc6a0

Run npm run build
a216bda

Merge pull request#77from simpleanalytics/codex/add-unit-tests-for-…
aa513da
…auto-events [no ci] Add auto-events unit tests

Fix delayed phone link events
78bc66d

Merge pull request#76from simpleanalytics/codex/add-tel--clicks-to-…
dc116ae
…auto-events Add tel link tracking

adriaandotcom added 2 commits July 29, 2025 15:36

fix allowParams regex to be case insensitive
9294410

Merge pull request#81from simpleanalytics/codex/make-allow-params-r…
c869bb0
…egex-case-insensitive Fix allowParams case sensitivity

adriaandotcom marked this pull request as draft March 3, 2026 10:41

Simple Analytics Codex added 5 commits August 12, 2026 01:11

Merge main into v12
443ee6b
Resolve PR #40 conflicts while retaining the v12 dist artifacts. Keep main's BrowserStack workflow and nested-link click handling, and combine the test scripts from both branches.

Fix merged BrowserStack test setup
52d297e

Collect compact query parameter names via ignore metrics
3e8bc7e

Run BrowserStack tests on Node.js 22.16
c70cae6

Use numeric BrowserStack test exit codes
84ef41b

Navigation Menu

Uh oh!

v12 - #40

v12#40
adriaandotcom wants to merge 72 commits into
mainfrom
v12

adriaandotcom commented May 12, 2023•
edited
Loading

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

cursorBot commented Jul 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

adriaandotcom commented May 12, 2023• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

cursorBot commented Jul 29, 2025

🚨 Bugbot Trial Expired

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

adriaandotcom commented May 12, 2023•
edited
Loading