Skip to content

added nuget job to generic helm template - #16

Merged
omarghatasheh merged 1 commit into
mainfrom
omarg
Dec 20, 2025
Merged

added nuget job to generic helm template#16
omarghatasheh merged 1 commit into
mainfrom
omarg

Conversation

@omarghatasheh

@omarghatashehomarghatasheh commented Dec 20, 2025

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Added NuGet package publishing capability to CI/CD pipeline with configurable semantic versioning, flexible project selection, customizable .NET versions, and optional test execution.
  • Chores

    • Extended pipeline infrastructure to support .NET package building and publishing workflows with secure credential management and customizable package distribution targets.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai

coderabbitaiBot commented Dec 20, 2025

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

Walkthrough

This pull request extends a GitHub Actions CI/CD workflow to add NuGet packaging capabilities. It introduces new workflow inputs for NuGet configuration, new secrets for authentication and source management, and a conditional NuGet job that performs checkout, semantic versioning, build/test, and package publishing operations.

Changes

Cohort / File(s)Summary
NuGet Packaging Workflow Integration
​.github/workflows/generic-chart-helm.yml
Added 7 new workflow inputs (package-nuget, nuget-major-version, nuget-minor-version, nuget-projects, dotnet-version, test-projects, run-tests), 2 new secrets (nuget-api-key, nuget-source), and a new nuget job with conditional execution. Job includes steps for checkout, semantic versioning determination, dotnet restore/build/test, and NuGet pack/push operations.

Sequence Diagram

sequenceDiagram
participant GH as GitHub Actions
participant CO as Checkout Action
participant SV as Semver Action
participant DB as Dotnet Build
participant PP as Pack & Push
GH->>GH: Check if package-nuget enabled
alt package-nuget = true
GH->>CO: Checkout repository
CO-->>GH: Code ready
GH->>SV: Determine semantic version<br/>(major, minor inputs)
SV-->>GH: Version calculated
GH->>DB: Restore & Build projects<br/>Run tests if enabled
DB-->>GH: Build & tests complete
GH->>PP: Pack & Push to NuGet<br/>(version, api-key, source)
PP-->>GH: Package published
end
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Review the new workflow inputs for completeness and correct default/required status
  • Verify the conditional logic for the NuGet job (if: ${{ inputs.package-nuget }})
  • Confirm that all NuGet-related secrets are properly passed to the pack/push action
  • Validate that semantic versioning inputs integrate correctly with the version derivation step

Poem

🐰 With inputs galore and secrets so keen,
A NuGet pipeline now joins the scene!
From checkout to semver, build to the end,
Packages flow forth—release, my dear friend! 📦✨

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch omarg

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4c0acbe and 55555eb.

📒 Files selected for processing (1)
  • .github/workflows/generic-chart-helm.yml (3 hunks)

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@omarghatasheh