fix(chat-subs): always use getBaseUrl helper to fetch base url

[icecrasher321]

Summary

Replace all access patterns of NEXT_PUBLIC_APP_URL with getBaseUrl() to centralize logic.

Type of Change

• Bug fix

Testing

Manually with @aadamgough

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Oct 15, 2025 9:06pm

[greptile-apps]

Greptile Overview

Summary

Fixed Microsoft Teams webhook creation to always use NEXT_PUBLIC_APP_URL instead of request origin, ensuring Microsoft Graph API receives a valid HTTPS endpoint.

• Removed conditional logic that attempted to use request origin with localhost fallback
• Added explicit validation that NEXT_PUBLIC_APP_URL is configured before attempting subscription creation
• Ensures Microsoft Graph API can reliably reach the public webhook endpoint for notifications
• Aligns with similar pattern already used in createTelegramWebhook and createAirtableWebhookSubscription

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The change is a straightforward bug fix that simplifies the logic and makes it more robust. It removes conditional request origin logic that could fail with Microsoft Graph API and replaces it with a reliable environment variable approach. The pattern matches existing implementations for Telegram and Airtable webhooks. Since NEXT_PUBLIC_APP_URL is a required environment variable (defined with z.string().url() in env.ts:244), the validation ensures proper configuration.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
apps/sim/lib/webhooks/webhook-helpers.ts	5/5	Replaced request origin logic with strict NEXT_PUBLIC_APP_URL requirement to ensure Microsoft Graph can reach public HTTPS endpoint

Sequence Diagram

sequenceDiagram
participant Client
participant WebhookAPI as Webhook API Route
participant Helper as createTeamsSubscription
participant Env as Environment Config
participant MSGraph as Microsoft Graph API
Client->>WebhookAPI: POST /api/webhooks (create Teams webhook)
WebhookAPI->>Helper: createTeamsSubscription(request, webhook, workflow)
Helper->>Env: Check NEXT_PUBLIC_APP_URL
alt NEXT_PUBLIC_APP_URL not set
Env-->>Helper: undefined
Helper->>Helper: Log error
Helper-->>WebhookAPI: return false
WebhookAPI-->>Client: 500 Error
else NEXT_PUBLIC_APP_URL configured
Env-->>Helper: https://app.sim.ai
Helper->>Helper: Build notificationUrl with NEXT_PUBLIC_APP_URL
Helper->>MSGraph: POST /subscriptions (with HTTPS notificationUrl)
MSGraph-->>Helper: Subscription created
Helper->>Helper: Update webhook with subscription ID
Helper-->>WebhookAPI: return true
WebhookAPI-->>Client: 200 Success
end

Loading

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}