Skip to content

fix(conn-status): remove unused connection status inside user avatar stack - #1800

Merged
icecrasher321 merged 1 commit into
stagingfrom
fix/connection-status
Nov 3, 2025
Merged

fix(conn-status): remove unused connection status inside user avatar stack#1800
icecrasher321 merged 1 commit into
stagingfrom
fix/connection-status

Conversation

@icecrasher321

Copy link
Copy Markdown
Collaborator

Summary

Redundant indicator to indicate sockets failures. Showed up since we re-enabled user avatar stack recently.

Type of Change

  • Bug fix

Testing

Tested Manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercelBot commented Nov 3, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentPreviewCommentsUpdated (UTC)
docsSkippedSkippedNov 3, 2025 11:04pm

@greptile-appsgreptile-appsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

Removed redundant connection status indicator from the UserAvatarStack component. The connection status was already being displayed by the ControlBar component via renderDisconnectionNotice() (control-bar.tsx:1216-1241), which shows a prominent red banner with WifiOff icon when userPermissions.isOfflineMode is true.

Key changes:

  • Deleted the entire ConnectionStatus component file (65 lines)
  • Removed unused imports: ConnectionStatus component and useCollaborativeWorkflow hook
  • Removed unused state variables: isConnected and hasOperationError
  • Cleaned up UI spacing by removing gap-2 from the wrapper div

Analysis:
The ControlBar component already handles connection status display at the top-right of the screen, making the connection status inside the user avatar stack redundant. This PR eliminates duplicate functionality and simplifies the component tree.

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The changes are straightforward cleanup that removes redundant functionality. The connection status is still properly displayed by the ControlBar component's renderDisconnectionNotice() function, ensuring no loss of functionality. The PR only removes duplicate code, cleans up unused imports/state, and makes minor spacing adjustments.
  • No files require special attention

Important Files Changed

File Analysis

FilenameScoreOverview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/control-bar/components/user-avatar-stack/components/connection-status/connection-status.tsx5/5Removed entire file containing redundant connection status indicator component
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/control-bar/components/user-avatar-stack/user-avatar-stack.tsx5/5Removed unused imports and ConnectionStatus component rendering, cleaned up gap-2 spacing

Sequence Diagram

sequenceDiagram
participant User
participant Workflow
participant ControlBar
participant UserAvatarStack
participant usePresence
User->>Workflow: Loads workflow page
Workflow->>ControlBar: Renders control bar
Note over ControlBar: renderDisconnectionNotice()<br/>displays connection status
Workflow->>UserAvatarStack: Renders user avatar stack
UserAvatarStack->>usePresence: Get presence users
usePresence-->>UserAvatarStack: Returns user list
UserAvatarStack->>UserAvatarStack: Display user avatars
Note over UserAvatarStack: Previously displayed<br/>redundant ConnectionStatus<br/>(now removed)
Loading

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@icecrasher321
icecrasher321 merged commit d1fcade into stagingNov 3, 2025
9 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/connection-status branch November 6, 2025 01:25
@waleedlatif1waleedlatif1 mentioned this pull request Nov 12, 2025
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@icecrasher321