Skip to content

fix(hitl): rename uiurl to url - #1855

Merged
Sg312 merged 1 commit into
stagingfrom
fix/hitl-output
Nov 8, 2025
Merged

fix(hitl): rename uiurl to url#1855
Sg312 merged 1 commit into
stagingfrom
fix/hitl-output

Conversation

@Sg312

@Sg312Sg312 commented Nov 8, 2025

Copy link
Copy Markdown
Collaborator

Summary

Rename uiurl to url

Type of Change

  • Bug fix

Testing

Manual test

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercelBot commented Nov 8, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentPreviewCommentsUpdated (UTC)
docsSkippedSkippedNov 8, 2025 3:48am

@greptile-appsgreptile-appsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greptile Overview

Greptile Summary

Renamed the approval block's output field from uiUrl to url to simplify the API. The change is consistently applied across the block definition, UI components, executor, handlers, and output utilities.

Key changes:

  • Block configuration updated to expose url instead of uiUrl as output
  • Tag dropdown filtering logic updated to match .url instead of .uiUrl
  • All output mappings now set output.url from resumeLinks.uiUrl
  • Comments updated to reflect the rename

Note: The internal resumeLinks type still uses uiUrl property name, which is acceptable as an internal implementation detail that gets mapped to the public-facing url field.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • This is a straightforward field rename with consistent implementation across all relevant files. The changes are well-coordinated and don't introduce any logical errors. The internal resumeLinks.uiUrl property is properly mapped to the new output.url field throughout.
  • No files require special attention

Important Files Changed

File Analysis

FilenameScoreOverview
apps/sim/blocks/blocks/pause_resume.ts5/5Renamed output field from uiUrl to url in block configuration
apps/sim/components/ui/tag-dropdown.tsx5/5Updated self-reference filter to match renamed url field instead of uiUrl
apps/sim/executor/execution/block-executor.ts5/5Updated placeholder state output to use url field mapped from resumeLinks.uiUrl
apps/sim/executor/handlers/pause-resume/pause-resume-handler.ts5/5Updated pause/resume output to use url field instead of uiUrl
apps/sim/lib/workflows/block-outputs.ts5/5Updated approval block output definition to use url field
apps/sim/lib/workflows/executor/pause-resume-manager.ts5/5Updated merged output mapping to use url field from resumeLinks.uiUrl

Sequence Diagram

sequenceDiagram
participant User
participant Workflow
participant PauseResumeHandler
participant BlockExecutor
participant PauseResumeManager
participant Output
User->>Workflow: Execute workflow with approval block
Workflow->>BlockExecutor: Execute approval block
BlockExecutor->>PauseResumeHandler: Handle pause/resume
PauseResumeHandler->>PauseResumeHandler: Generate resumeLinks<br/>(contains uiUrl property)
PauseResumeHandler->>Output: Map resumeLinks.uiUrl to output.url
BlockExecutor->>BlockExecutor: Create placeholder state<br/>with output.url
BlockExecutor->>PauseResumeManager: Register pause point
PauseResumeManager->>PauseResumeManager: Merge output<br/>map resumeLinks.uiUrl to url
PauseResumeManager->>Output: Return merged output with url field
Output->>User: Workflow paused with url field available
Loading

Additional Comments (1)

  1. apps/sim/executor/types.ts, line 35 (link)

    style: The resumeLinks type still uses uiUrl but the output field was renamed to url. While the mapping from resumeLinks.uiUrl to output.url works, this creates inconsistency in naming. Consider whether resumeLinks.uiUrl should remain as is (internal) or be renamed for consistency.

6 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@Sg312
Sg312 merged commit 3f435ce into stagingNov 8, 2025
9 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/hitl-output branch November 8, 2025 23:27
waleedlatif1 pushed a commit that referenced this pull request Nov 9, 2025
waleedlatif1 pushed a commit that referenced this pull request Nov 12, 2025
@waleedlatif1waleedlatif1 mentioned this pull request Nov 12, 2025
10 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Sg312