fix(copilot): fix triggers unsave on edit

[Sg312]

Summary

Triggers used to unsave on edit, they shouldn't

Type of Change

• Bug fix

Testing

Manual

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Nov 10, 2025 11:18pm

[greptile-apps]

Greptile Overview

Greptile Summary

Fixed trigger metadata (webhookId, triggerPath, testUrl, testUrlExpiresAt) being incorrectly cleared when copilot edits workflows, by introducing centralized constants that categorize trigger-related subblocks and protecting runtime metadata from modification.

Key changes:

• Defined TRIGGER_RUNTIME_SUBBLOCK_IDS in triggers/consts.ts to identify metadata that should never be modified by diff operations
• Modified edit-workflow.ts to skip runtime trigger subblocks during copilot edits and added applyTriggerConfigToBlockSubblocks() to properly handle triggerConfig changes
• Updated json-sanitizer.ts to exclude persisted trigger subblocks from sensitive data filtering (previously they were incorrectly marked as sensitive)
• Removed hardcoded WEBHOOK_SUBBLOCK_FIELDS filtering from utils.ts and server-utils.ts that was preventing trigger metadata from persisting
• Enhanced db-helpers.ts to restore existing webhooks after workflow saves (they were being deleted but not re-inserted)
• Fixed minor typo: "un-deployed" → "undeployed" in UI components

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The fix is well-architected and addresses a critical bug systematically. The centralized constants pattern is clean and maintainable. All changes are defensive (preventing overwrites) rather than introducing new logic. The webhook restoration logic ensures data integrity. No breaking changes or risky operations detected.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
apps/sim/triggers/consts.ts	5/5	Added centralized constants for trigger subblock IDs categorized by persistence and runtime behavior
apps/sim/lib/copilot/tools/server/workflow/edit-workflow.ts	5/5	Protected runtime trigger metadata from copilot edits and added logic to apply triggerConfig changes to subblocks
apps/sim/stores/workflows/utils.ts	5/5	Removed hardcoded WEBHOOK_SUBBLOCK_FIELDS filtering that was incorrectly excluding trigger metadata
apps/sim/stores/workflows/server-utils.ts	5/5	Removed hardcoded WEBHOOK_SUBBLOCK_FIELDS filtering that was incorrectly excluding trigger metadata
apps/sim/lib/workflows/db-helpers.ts	5/5	Added webhook persistence logic to restore existing webhooks after workflow save operations

Sequence Diagram

sequenceDiagram
participant User
participant UI as Trigger UI
participant Copilot
participant EditWorkflow as edit-workflow.ts
participant Sanitizer as json-sanitizer.ts
participant DBHelpers as db-helpers.ts
participant Store as Workflow Store
Note over User,Store: BEFORE FIX: Trigger metadata lost on copilot edit
User->>UI: Configure trigger (webhookId, triggerPath)
UI->>Store: Save trigger metadata to subblocks
User->>Copilot: Edit workflow via copilot
Copilot->>EditWorkflow: Apply edit operations
Note over EditWorkflow: ❌ Overwrites ALL subblock values<br/>including webhookId, triggerPath
EditWorkflow->>Store: Update workflow state
Note over Store: ❌ Trigger metadata lost
Note over User,Store: AFTER FIX: Trigger metadata preserved
User->>UI: Configure trigger (webhookId, triggerPath)
UI->>Store: Save trigger metadata to subblocks
User->>Copilot: Edit workflow via copilot
Copilot->>EditWorkflow: Apply edit operations
Note over EditWorkflow: ✓ Skip TRIGGER_RUNTIME_SUBBLOCK_IDS<br/>(webhookId, triggerPath, testUrl, etc)
EditWorkflow->>Store: Update workflow state (preserving trigger metadata)
Store->>Sanitizer: Export workflow for training
Note over Sanitizer: ✓ Keep TRIGGER_PERSISTED_SUBBLOCK_IDS<br/>(not marked as sensitive)
Store->>DBHelpers: Save workflow to database
Note over DBHelpers: ✓ Restore existing webhooks<br/>for blocks that still exist
DBHelpers->>Store: Workflow saved with webhooks intact

Loading

[greptile-apps]

_{9 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}