improvement(trigger-subflow): reuse helper code

[icecrasher321]

Summary

Reuse trigger utils func to check if trigger is in subflow.

Type of Change

• Other: code cleanup

Testing

Tested manually

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Nov 11, 2025 5:48am

[greptile-apps]

Greptile Overview

Greptile Summary

Refactored duplicate subflow validation logic by extracting it into a reusable TriggerUtils.isBlockInSubflow() helper function. This change eliminates code duplication between use-collaborative-workflow.ts and workflow/store.ts.

Key changes:

• Replaced inline parent block lookup and type checking with centralized TriggerUtils.isBlockInSubflow() call
• Simplified logging in workflow store by removing redundant parentId and parentType fields
• Improved code maintainability by consolidating the subflow detection logic in a single location

Confidence Score: 5/5

• This PR is safe to merge with no concerns - it's a clean refactoring that reduces code duplication
• Score reflects a straightforward refactoring with no logic changes, proper code reuse, and maintained functionality
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
apps/sim/hooks/use-collaborative-workflow.ts	5/5	Refactored duplicate subflow check logic to use centralized TriggerUtils.isBlockInSubflow() helper function
apps/sim/stores/workflows/workflow/store.ts	5/5	Refactored duplicate subflow check logic to use centralized TriggerUtils.isBlockInSubflow() helper function, simplified logging

Sequence Diagram

sequenceDiagram
participant User
participant CollaborativeHook as use-collaborative-workflow
participant WorkflowStore as workflow/store
participant TriggerUtils as TriggerUtils.isBlockInSubflow()
participant Blocks as blocks Record
User->>CollaborativeHook: Toggle trigger mode
CollaborativeHook->>TriggerUtils: isBlockInSubflow(id, blocks)
TriggerUtils->>Blocks: Find block by id
Blocks-->>TriggerUtils: block
TriggerUtils->>Blocks: Find parent by parentId
Blocks-->>TriggerUtils: parent
TriggerUtils->>TriggerUtils: Check parent.type === 'loop' || 'parallel'
TriggerUtils-->>CollaborativeHook: isInSubflow result
alt Block is in subflow
CollaborativeHook->>User: Dispatch warning event
else Block not in subflow
CollaborativeHook->>WorkflowStore: Execute toggle operation
end
User->>WorkflowStore: Toggle trigger mode (direct)
WorkflowStore->>TriggerUtils: isBlockInSubflow(id, blocks)
TriggerUtils->>Blocks: Find block by id
Blocks-->>TriggerUtils: block
TriggerUtils->>Blocks: Find parent by parentId
Blocks-->>TriggerUtils: parent
TriggerUtils->>TriggerUtils: Check parent.type === 'loop' || 'parallel'
TriggerUtils-->>WorkflowStore: isInSubflow result
alt Block is in subflow
WorkflowStore->>WorkflowStore: Log warning & return early
else Block not in subflow
WorkflowStore->>WorkflowStore: Toggle trigger mode & remove edges
end

Loading

[greptile-apps]

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}