Uh oh!
There was an error while loading. Please reload this page.
feat(registry): support multi-workflow delete - #1897
Merged
Conversation
waleedlatif1
marked this pull request as ready for review
November 11, 2025 20:48
Contributor
Greptile OverviewGreptile SummaryThis PR extends the workflow deletion system to support deleting multiple workflows at once. The implementation captures the selection state at right-click time, passes workflow IDs through a Key Changes:
Issues Found:
Confidence Score: 2/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant WorkflowItem
participant ContextMenu
participant DeleteModal
participant useDeleteWorkflow
participant FolderStore
participant WorkflowRegistry
participant Router
User->>WorkflowItem: Right-click workflow
WorkflowItem->>FolderStore: Get current selection
alt Workflow not selected
WorkflowItem->>FolderStore: selectOnly(workflow.id)
end
WorkflowItem->>FolderStore: Get final selection
WorkflowItem->>WorkflowItem: Capture workflowIds & names in ref
WorkflowItem->>ContextMenu: Show context menu
User->>ContextMenu: Click Delete
ContextMenu->>WorkflowItem: onDelete()
WorkflowItem->>DeleteModal: Open with captured selection
User->>DeleteModal: Confirm delete
DeleteModal->>useDeleteWorkflow: handleDeleteWorkflow()
useDeleteWorkflow->>useDeleteWorkflow: getWorkflowIds()
useDeleteWorkflow->>WorkflowRegistry: Get sidebarWorkflows
useDeleteWorkflow->>useDeleteWorkflow: Find activeWorkflowId
useDeleteWorkflow->>useDeleteWorkflow: Find nextWorkflowId
alt Active workflow being deleted
alt Next workflow exists
useDeleteWorkflow->>Router: Navigate to next workflow
else No remaining workflows
useDeleteWorkflow->>Router: Navigate to workspace root
end
end
useDeleteWorkflow->>WorkflowRegistry: Promise.all(removeWorkflow())
useDeleteWorkflow->>FolderStore: clearSelection()
useDeleteWorkflow->>DeleteModal: onSuccess()
DeleteModal->>User: Close modal
|
Comment on lines
+86
to
104
| // Find the first workflow that's not being deleted | ||
| const remainingWorkflows = sidebarWorkflows.filter( | ||
| (w) => !workflowIdsToDelete.includes(w.id) | ||
| ) | ||
| if (remainingWorkflows.length > 0) { | ||
| // Try to find the next workflow after the current one | ||
| const workflowsAfterCurrent = remainingWorkflows.filter((w) => { | ||
| const idx = sidebarWorkflows.findIndex((sw) => sw.id === w.id) | ||
| return idx > currentIndex | ||
| }) | ||
| if (workflowsAfterCurrent.length > 0) { | ||
| nextWorkflowId = workflowsAfterCurrent[0].id | ||
| } else { | ||
| // Otherwise, use the first remaining workflow | ||
| nextWorkflowId = remainingWorkflows[0].id | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
logic: navigation logic may fail when deleting multiple workflows. The currentIndex is based on the first workflow in workflowIdsToDelete, but if workflows are not sequential in the sidebar, the "after current" logic could skip better navigation candidates.
Example: If deleting workflows at positions [2, 5, 8] and currently viewing position 2, it would look for workflows after position 2, skipping position 1 which might be a better candidate.
Suggested change
| // Find the first workflow that's not being deleted | |
| constremainingWorkflows=sidebarWorkflows.filter( | |
| (w)=>!workflowIdsToDelete.includes(w.id) | |
| ) | |
| if(remainingWorkflows.length>0){ | |
| // Try to find the next workflow after the current one | |
| constworkflowsAfterCurrent=remainingWorkflows.filter((w)=>{ | |
| constidx=sidebarWorkflows.findIndex((sw)=>sw.id===w.id) | |
| returnidx>currentIndex | |
| }) | |
| if(workflowsAfterCurrent.length>0){ | |
| nextWorkflowId=workflowsAfterCurrent[0].id | |
| }else{ | |
| // Otherwise, use the first remaining workflow | |
| nextWorkflowId=remainingWorkflows[0].id | |
| } | |
| } | |
| letnextWorkflowId: string|null=null | |
| if(isActiveWorkflowBeingDeleted&&sidebarWorkflows.length>workflowIdsToDelete.length){ | |
| // Find the first workflow that's not being deleted | |
| constremainingWorkflows=sidebarWorkflows.filter( | |
| (w)=>!workflowIdsToDelete.includes(w.id) | |
| ) | |
| if(remainingWorkflows.length>0){ | |
| // Find the active workflow's current index | |
| constactiveWorkflowId=typeofisActive==='function' | |
| ? sidebarWorkflows.find(w=>workflowIdsToDelete.includes(w.id))?.id | |
| : workflowIdsToDelete[0] | |
| constactiveIndex=sidebarWorkflows.findIndex((w)=>w.id===activeWorkflowId) | |
| // Try to find the next workflow after the active one | |
| constworkflowsAfterActive=remainingWorkflows.filter((w)=>{ | |
| constidx=sidebarWorkflows.findIndex((sw)=>sw.id===w.id) | |
| returnidx>activeIndex | |
| }) | |
| if(workflowsAfterActive.length>0){ | |
| nextWorkflowId=workflowsAfterActive[0].id | |
| }else{ | |
| // Otherwise, use the last remaining workflow (closest before active) | |
| nextWorkflowId=remainingWorkflows[remainingWorkflows.length-1].id | |
| } | |
| } | |
| } |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/app/workspace/[workspaceId]/w/hooks/use-delete-workflow.ts
Line: 86:104
Comment:
**logic:** navigation logic may fail when deleting multiple workflows. The `currentIndex` is based on the first workflow in `workflowIdsToDelete`, but if workflows are not sequential in the sidebar, the "after current" logic could skip better navigation candidates.
Example: If deleting workflows at positions [2, 5, 8] and currently viewing position 2, it would look for workflows after position 2, skipping position 1 which might be a better candidate.
```suggestion let nextWorkflowId: string | null = null if (isActiveWorkflowBeingDeleted && sidebarWorkflows.length > workflowIdsToDelete.length) { // Find the first workflow that's not being deleted const remainingWorkflows = sidebarWorkflows.filter( (w) => !workflowIdsToDelete.includes(w.id) ) if (remainingWorkflows.length > 0) { // Find the active workflow's current index const activeWorkflowId = typeof isActive === 'function' ? sidebarWorkflows.find(w => workflowIdsToDelete.includes(w.id))?.id : workflowIdsToDelete[0] const activeIndex = sidebarWorkflows.findIndex((w) => w.id === activeWorkflowId) // Try to find the next workflow after the active one const workflowsAfterActive = remainingWorkflows.filter((w) => { const idx = sidebarWorkflows.findIndex((sw) => sw.id === w.id) return idx > activeIndex }) if (workflowsAfterActive.length > 0) { nextWorkflowId = workflowsAfterActive[0].id } else { // Otherwise, use the last remaining workflow (closest before active) nextWorkflowId = remainingWorkflows[remainingWorkflows.length - 1].id } } }```
How can I resolve this? If you propose a fix, please make it concise.The latest updates on your projects. Learn more about Vercel for GitHub. |
waleedlatif1
commented
Nov 11, 2025
CollaboratorAuthor
Uh oh!
There was an error while loading. Please reload this page.
Comment on lines
+83
to
+90
| let activeWorkflowId: string | null = null | ||
| if (isActiveWorkflowBeingDeleted && typeof isActive === 'function') { | ||
| // Check each workflow being deleted to find which one is active | ||
| activeWorkflowId = | ||
| workflowIdsToDelete.find((id) => isActive([id])) || workflowIdsToDelete[0] | ||
| } else { | ||
| activeWorkflowId = workflowIdsToDelete[0] | ||
| } |
Contributor
There was a problem hiding this comment.
logic: logic issue: incorrect activeWorkflowId when isActive is a function. Line 87 recursively calls isActive with a single-element array, but isActive expects the full array. This returns the wrong result.
Example: Deleting workflows ['id1', 'id2', 'id3'], active is 'id2'. Line 86 will call isActive(['id1']), which returns false, so defaults to workflowIdsToDelete[0] ('id1'), even though 'id2' is the active one.
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/app/workspace/[workspaceId]/w/hooks/use-delete-workflow.ts
Line: 83:90
Comment:
**logic:** logic issue: incorrect `activeWorkflowId` when `isActive` is a function. Line 87 recursively calls `isActive` with a single-element array, but `isActive` expects the full array. This returns the wrong result.
Example: Deleting workflows ['id1', 'id2', 'id3'], active is 'id2'. Line 86 will call `isActive(['id1'])`, which returns false, so defaults to `workflowIdsToDelete[0]` ('id1'), even though 'id2' is the active one.
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+126
to
+128
| const workflowNames = workflowIds | ||
| .map((id) => workflows[id]?.name) | ||
| .filter((name): name is string => !!name) |
Contributor
There was a problem hiding this comment.
logic: potential issue: if some workflows don't have names (undefined), workflowNames could be empty, causing incorrect modal text. Should include fallback like "Untitled Workflow".
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/app/workspace/[workspaceId]/w/components/sidebar/components-new/workflow-list/components/workflow-item/workflow-item.tsx
Line: 126:128
Comment:
**logic:** potential issue: if some workflows don't have names (undefined), `workflowNames` could be empty, causing incorrect modal text. Should include fallback like "Untitled Workflow".
How can I resolve this? If you propose a fix, please make it concise.waleedlatif1 added a commit
that referenced
this pull request
Nov 12, 2025
* feat(registry): support multi-workflow delete * added intelligent next index selection if deleting active workflow
waleedlatif1 added a commit
that referenced
this pull request
Nov 12, 2025
* feat(registry): support multi-workflow delete * added intelligent next index selection if deleting active workflow
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist