fix(start): fix start block numbering

[Sg312]

Summary

Fixes start block numbering issue. Prevents duplication and if deleted then added, doesn't have a number suffix

Type of Change

• Bug fix

Testing

Manual

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Nov 12, 2025 1:43am

[greptile-apps]

Greptile Overview

Greptile Summary

This PR implements consistent handling of start blocks across both legacy (starter) and unified (start_trigger) types to prevent duplication and numbering issues.

Key changes:

• Unified block naming to always return "Start" without numbers for start blocks in getUniqueBlockName
• Added duplication prevention for both starter and start_trigger types in the collaborative workflow hook
• Updated START_CONFLICT_TYPES to include legacy TRIGGER_TYPES.STARTER to prevent coexistence with modern triggers
• Modified action bar to handle both start block types consistently, enabling delete functionality for unified start blocks

How it fits with the codebase:
The changes build upon the existing trigger classification system in lib/workflows/triggers.ts, which already distinguishes between legacy starter blocks and the unified start_trigger. By treating both types uniformly in UI components and workflow operations, this ensures a smooth migration path from the legacy system to the unified trigger approach while maintaining backward compatibility.

Confidence Score: 4/5

• This PR is safe to merge with one minor verification needed around duplicate name handling
• The changes correctly implement start block handling across multiple layers (UI, workflow operations, naming). The logic is sound and consistent. Score is 4/5 due to one concern: the early return in getUniqueBlockName bypasses duplicate checking, relying on upstream validation to prevent conflicts. This should be verified in testing.
• Verify apps/sim/stores/workflows/utils.ts - ensure the early return for start blocks doesn't cause naming conflicts in edge cases

Important Files Changed

File Analysis

Filename	Score	Overview
apps/sim/stores/workflows/utils.ts	4/5	Added special case to always name start blocks as 'Start' without numbering, preventing duplication
apps/sim/lib/workflows/triggers.ts	5/5	Added legacy TRIGGER_TYPES.STARTER to START_CONFLICT_TYPES array to prevent coexistence with unified start_trigger
apps/sim/hooks/use-collaborative-workflow.ts	5/5	Added duplication prevention for both starter and start_trigger block types in collaborativeDuplicateBlock function
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/workflow-block/components/action-bar/action-bar.tsx	5/5	Unified handling of starter and start_trigger blocks by introducing isStartBlock check, enabled delete button for start blocks

Sequence Diagram

sequenceDiagram
participant User
participant ActionBar
participant CollaborativeWorkflow
participant WorkflowStore
participant Utils
participant TriggerUtils
Note over User,TriggerUtils: Start Block Duplication Prevention Flow
User->>ActionBar: Attempts to duplicate start block
ActionBar->>ActionBar: Check isStartBlock (starter OR start_trigger)
ActionBar->>CollaborativeWorkflow: collaborativeDuplicateBlock(blockId)
CollaborativeWorkflow->>WorkflowStore: Get source block
CollaborativeWorkflow->>CollaborativeWorkflow: Check if starter OR start_trigger
alt Is Start Block
CollaborativeWorkflow->>CollaborativeWorkflow: Log warning & return early
CollaborativeWorkflow-->>User: Duplication prevented
else Not Start Block
CollaborativeWorkflow->>Utils: getUniqueBlockName(sourceName, blocks)
alt Block name is "Start" or "Starter"
Utils->>Utils: Normalize name (lowercase, remove spaces)
Utils-->>CollaborativeWorkflow: Return "Start" (no number)
else Other block types
Utils->>Utils: Find highest number suffix
Utils-->>CollaborativeWorkflow: Return "BlockName N+1"
end
CollaborativeWorkflow->>WorkflowStore: Create new block with unique name
CollaborativeWorkflow-->>User: Block duplicated successfully
end
Note over User,TriggerUtils: Start Block Conflict Prevention Flow
User->>WorkflowStore: Attempts to add start_trigger
WorkflowStore->>TriggerUtils: wouldViolateSingleInstance(blocks, type)
TriggerUtils->>TriggerUtils: Check START_CONFLICT_TYPES array
alt Has legacy starter OR existing start_trigger
TriggerUtils-->>WorkflowStore: Violation detected
WorkflowStore-->>User: Addition blocked
else No conflicts
TriggerUtils-->>WorkflowStore: Allowed
WorkflowStore->>WorkflowStore: Add block
WorkflowStore-->>User: Block added successfully
end

Loading

[greptile-apps]

_{4 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[greptile-apps]

style: early return bypasses duplicate name checking - verify that duplication prevention in use-collaborative-workflow.ts:1197 prevents naming conflicts when adding start blocks

Prompt To Fix With AI

This is a comment left during a code review.
Path: apps/sim/stores/workflows/utils.ts
Line: 24:26
Comment:
**style:** early return bypasses duplicate name checking - verify that duplication prevention in `use-collaborative-workflow.ts:1197` prevents naming conflicts when adding start blocks
How can I resolve this? If you propose a fix, please make it concise.