Uh oh!
There was an error while loading. Please reload this page.
feat(tag-dropdown): added start block to tag dropdown by default - #1922
Merged
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. |
Uh oh!
There was an error while loading. Please reload this page.
Contributor
Greptile OverviewGreptile SummaryAdded support for displaying the start block (
The changes maintain consistency with existing patterns and improve the robustness of input format handling. Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant User
participant TagDropdown
participant BlockOutputs
participant AccessiblePrefixes
participant WorkflowStore
User->>TagDropdown: Types < to trigger dropdown
TagDropdown->>AccessiblePrefixes: Get accessible blocks
AccessiblePrefixes->>WorkflowStore: Query blocks, edges, loops, parallels
AccessiblePrefixes->>AccessiblePrefixes: Find starter/start_trigger block
AccessiblePrefixes-->>TagDropdown: Return accessible block IDs
TagDropdown->>BlockOutputs: Get output paths for each block
BlockOutputs->>BlockOutputs: Filter empty field names
BlockOutputs-->>TagDropdown: Return valid output paths
TagDropdown->>TagDropdown: Check if root tag should show
Note over TagDropdown: Shows root tag for<br/>generic_webhook OR start_trigger
TagDropdown->>TagDropdown: Build tag list with block outputs
TagDropdown-->>User: Display filtered tags in dropdown
|
Comment on lines
+642
to
+643
| const shouldShowRootTag = | ||
| sourceBlock.type === TRIGGER_TYPES.GENERIC_WEBHOOK || sourceBlock.type === 'start_trigger' |
Contributor
There was a problem hiding this comment.
style: use constant TRIGGER_TYPES.START instead of string literal
Suggested change
| constshouldShowRootTag= | |
| sourceBlock.type===TRIGGER_TYPES.GENERIC_WEBHOOK||sourceBlock.type==='start_trigger' | |
| constshouldShowRootTag= | |
| sourceBlock.type===TRIGGER_TYPES.GENERIC_WEBHOOK||sourceBlock.type===TRIGGER_TYPES.START |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel-new/components/editor/components/sub-block/components/tag-dropdown/tag-dropdown.tsx
Line: 642:643
Comment:
**style:** use constant `TRIGGER_TYPES.START` instead of string literal
```suggestion const shouldShowRootTag = sourceBlock.type === TRIGGER_TYPES.GENERIC_WEBHOOK || sourceBlock.type === TRIGGER_TYPES.START```
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+955
to
+957
| const shouldShowRootTag = | ||
| accessibleBlock.type === TRIGGER_TYPES.GENERIC_WEBHOOK || | ||
| accessibleBlock.type === 'start_trigger' |
Contributor
There was a problem hiding this comment.
style: use constant TRIGGER_TYPES.START instead of string literal
Suggested change
| constshouldShowRootTag= | |
| accessibleBlock.type===TRIGGER_TYPES.GENERIC_WEBHOOK|| | |
| accessibleBlock.type==='start_trigger' | |
| constshouldShowRootTag= | |
| accessibleBlock.type===TRIGGER_TYPES.GENERIC_WEBHOOK|| | |
| accessibleBlock.type===TRIGGER_TYPES.START |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel-new/components/editor/components/sub-block/components/tag-dropdown/tag-dropdown.tsx
Line: 955:957
Comment:
**style:** use constant `TRIGGER_TYPES.START` instead of string literal
```suggestion const shouldShowRootTag = accessibleBlock.type === TRIGGER_TYPES.GENERIC_WEBHOOK || accessibleBlock.type === TRIGGER_TYPES.START```
How can I resolve this? If you propose a fix, please make it concise.
Comment on lines
+30
to
+32
| const starterBlock = Object.values(blocks).find( | ||
| (block) => block.type === 'starter' || block.type === 'start_trigger' | ||
| ) |
Contributor
There was a problem hiding this comment.
style: use constant TRIGGER_TYPES.START instead of string literal. Import TRIGGER_TYPES from @/lib/workflows/triggers
Suggested change
| conststarterBlock=Object.values(blocks).find( | |
| (block)=>block.type==='starter'||block.type==='start_trigger' | |
| ) | |
| conststarterBlock=Object.values(blocks).find( | |
| (block)=>block.type==='starter'||block.type===TRIGGER_TYPES.START | |
| ) |
Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-accessible-reference-prefixes.ts
Line: 30:32
Comment:
**style:** use constant `TRIGGER_TYPES.START` instead of string literal. Import `TRIGGER_TYPES` from `@/lib/workflows/triggers````suggestion const starterBlock = Object.values(blocks).find( (block) => block.type === 'starter' || block.type === TRIGGER_TYPES.START )```
How can I resolve this? If you propose a fix, please make it concise.waleedlatif1 added a commit
that referenced
this pull request
Nov 12, 2025
waleedlatif1 added a commit
that referenced
this pull request
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Type of Change
Testing
Tested manually
Checklist