improvement(subflow): remove all associated edges when moving a block into a subflow

[waleedlatif1]

Summary

• remove all associated edges when moving a block into a subflow, we already disallowed external edges that cross the boundary, and remove all edges when moving a block out of a subflow

Type of Change

• Bug fix

Testing

Tested manually

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Preview	Comments	Updated (UTC)
docs	Skipped			Dec 1, 2025 7:10am

[greptile-apps]

Greptile Overview

Greptile Summary

This PR improves subflow edge management by ensuring all connected edges are removed when moving a block into a subflow container, matching the existing behavior when removing blocks from subflows.

Key Changes:

• Extracted edge removal logic into reusable removeEdgesForNode helper function
• Added edge cleanup when moving blocks into subflow containers (previously only removed when moving out)
• Updated affectedEdges tracking to include both removed and added edges for proper undo/redo support
• Refactored remove-from-subflow handler to use the new helper function

The implementation properly handles undo/redo by batching edge operations with the parent update event, preventing individual edge recordings that would clutter the history.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The changes are well-structured and follow established patterns. The refactoring extracts duplicate logic into a reusable helper function with proper error handling via try/finally blocks. The implementation correctly manages undo/redo state by batching edge operations with parent updates. The code maintains consistency with existing edge removal behavior when moving blocks out of subflows.
• No files require special attention

Important Files Changed

File Analysis

Filename	Score	Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx	5/5	Refactored edge removal logic into reusable helper function and added edge cleanup when moving blocks into subflows

Sequence Diagram

sequenceDiagram
participant User
participant Workflow
participant removeEdgesForNode
participant updateNodeParent
participant UndoRedo
alt Moving Block INTO Subflow
User->>Workflow: Drag block into subflow container
Workflow->>Workflow: Filter edges connected to block
Workflow->>removeEdgesForNode: removeEdgesForNode(blockId, edgesToRemove)
removeEdgesForNode->>removeEdgesForNode: Dispatch skip-edge-recording (true)
loop For each edge
removeEdgesForNode->>Workflow: removeEdge(edge.id)
end
removeEdgesForNode->>removeEdgesForNode: Dispatch skip-edge-recording (false)
Workflow->>Workflow: Compute auto-connect edges (edgesToAdd)
Workflow->>Workflow: Combine affectedEdges = [...edgesToRemove, ...edgesToAdd]
Workflow->>updateNodeParent: updateNodeParent(blockId, parentId, affectedEdges)
updateNodeParent->>UndoRedo: Record parent update with all affected edges
loop For each new edge
Workflow->>Workflow: addEdge(edge)
end
end
alt Moving Block OUT of Subflow
User->>Workflow: Trigger remove-from-subflow event
Workflow->>Workflow: Filter edges connected to block
Workflow->>removeEdgesForNode: removeEdgesForNode(blockId, edgesToRemove)
removeEdgesForNode->>removeEdgesForNode: Dispatch skip-edge-recording (true)
loop For each edge
removeEdgesForNode->>Workflow: removeEdge(edge.id)
end
removeEdgesForNode->>removeEdgesForNode: Dispatch skip-edge-recording (false)
Workflow->>updateNodeParent: updateNodeParent(blockId, null, edgesToRemove)
updateNodeParent->>UndoRedo: Record parent update with removed edges
end

Loading

[greptile-apps]

Additional Comments (1)

1. apps/sim/app/workspace/[workspaceId]/w/[workflowId]/workflow.tsx, line 2006-2020 (link)

   logic: Missing removeEdgesForNode and edgesForDisplay in dependency array

_{1 file reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

[waleedlatif1]

@greptile

[greptile-apps]

_{1 file reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}