Skip to content

fix(selector): remove subblock state prop for subblock component#2151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
icecrasher321 merged 1 commit into from
Dec 1, 2025
Merged

fix(selector): remove subblock state prop for subblock component #2151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions ...eId]/w/[workflowId]/components/panel/components/editor/components/sub-block/sub-block.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -346,10 +346,11 @@ function SubBlockComponent({
| undefined

// Use dependsOn gating to compute final disabled state
// Only pass previewContextValues when in preview mode to avoid format mismatches
const { finalDisabled: gatedDisabled } = useDependsOnGate(blockId, config, {
disabled,
isPreview,
previewContextValues: subBlockValues,
previewContextValues: isPreview ? subBlockValues : undefined,
})

const isDisabled = gatedDisabled
Expand DownExpand Up@@ -611,7 +612,7 @@ function SubBlockComponent({
disabled={isDisabled}
isPreview={isPreview}
previewValue={previewValue}
previewContextValues={subBlockValues}
previewContextValues={isPreview ? subBlockValues : undefined}
/>
)

Expand Down
1 change: 0 additions & 1 deletion .../app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/editor.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -353,7 +353,6 @@ export function Editor() {
blockId={currentBlockId}
config={subBlock}
isPreview={false}
subBlockValues={subBlockState}
disabled={!userPermissions.canEdit}
fieldDiffStatus={undefined}
allowExpandInPreview={false}
Expand Down