Skip to content

fix(jira): fixed incorrect dependsOn for jira project/issue subblocks - #2167

Merged
waleedlatif1 merged 1 commit into
stagingfrom
fix/jira
Dec 3, 2025
Merged

fix(jira): fixed incorrect dependsOn for jira project/issue subblocks#2167
waleedlatif1 merged 1 commit into
stagingfrom
fix/jira

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • fixed incorrect dependsOn for jira project/issue subblocks

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercelBot commented Dec 3, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
ProjectDeploymentPreviewCommentsUpdated (UTC)
docsSkippedSkippedDec 3, 2025 4:16am

@waleedlatif1
waleedlatif1 merged commit a6e3c92 into stagingDec 3, 2025
5 checks passed
@waleedlatif1
waleedlatif1 deleted the fix/jira branch December 3, 2025 04:18
@greptile-apps

Copy link
Copy Markdown
Contributor

Greptile Overview

Greptile Summary

Fixed the dependsOn property for summary and description subblocks from ['issueKey'] to ['projectId'] to correctly support both write and update operations.

  • Previous behavior: Fields depended on issueKey, which prevented them from showing during "Write Issue" operation since no issue exists yet
  • New behavior: Fields depend on projectId, which is required for both operations and appears earlier in the dependency chain (credential → domain → projectId → issueKey)
  • This ensures the UI fields are enabled at the appropriate time for both creating new issues and updating existing ones

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The change is a targeted bug fix that corrects the dependency chain for form fields. The fix aligns with the existing dependency hierarchy where projectId is selected before issueKey, and both write and update operations require projectId. No logical errors or breaking changes introduced.
  • No files require special attention

Important Files Changed

File Analysis

FilenameScoreOverview
apps/sim/blocks/blocks/jira.ts5/5Fixed dependency chain for summary/description fields to properly support both write and update operations

Sequence Diagram

sequenceDiagram
participant User
participant JiraBlock
participant SubBlocks
participant Validation
Note over User,Validation: Write Operation Flow
User->>JiraBlock: Select "Write Issue"
JiraBlock->>SubBlocks: Show credential & domain fields
User->>SubBlocks: Enter credential & domain
SubBlocks->>SubBlocks: Enable projectId selector (dependsOn satisfied)
User->>SubBlocks: Select projectId
SubBlocks->>SubBlocks: Enable summary & description (dependsOn: projectId ✓)
User->>SubBlocks: Enter summary & description
User->>JiraBlock: Submit
JiraBlock->>Validation: Validate projectId required
Validation->>JiraBlock: Pass
JiraBlock->>JiraBlock: Create new issue
Note over User,Validation: Update Operation Flow
User->>JiraBlock: Select "Update Issue"
JiraBlock->>SubBlocks: Show credential & domain fields
User->>SubBlocks: Enter credential & domain
SubBlocks->>SubBlocks: Enable projectId selector (dependsOn satisfied)
User->>SubBlocks: Select projectId
SubBlocks->>SubBlocks: Enable issueKey selector (dependsOn: projectId ✓)
SubBlocks->>SubBlocks: Enable summary & description (dependsOn: projectId ✓)
User->>SubBlocks: Select issueKey
User->>SubBlocks: Update summary & description
User->>JiraBlock: Submit
JiraBlock->>Validation: Validate projectId & issueKey required
Validation->>JiraBlock: Pass
JiraBlock->>JiraBlock: Update existing issue
Loading

@greptile-appsgreptile-appsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1