fix(deploy): fix workflow change detection to handle old variable reference format

[waleedlatif1]

Summary

• fix workflow change detection to handle old variable reference format

Type of Change

• Bug fix

Testing

Tested manually

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Review	Updated (UTC)
docs	Skipped		Dec 29, 2025 10:05am

[greptile-apps]

Greptile Summary

Fixed workflow change detection to properly handle legacy variable storage formats and UI-only fields. The fix addresses two issues:

• Old deployed workflows stored variables as empty arrays instead of objects, causing comparison failures
• The validationError field (UI-only) was triggering false change detection

Changes:

• Added normalizeVariables() to convert legacy empty array format to object
• Added sanitizeVariable() to strip UI-only validationError field before comparison
• Updated variable comparison in hasWorkflowChanged() to use both normalization functions
• Added 6 comprehensive test cases covering all edge cases

The implementation follows existing patterns (sanitizeTools, sanitizeInputFormat) and ensures backward compatibility.

Confidence Score: 5/5

• This PR is safe to merge with minimal risk
• The fix is well-tested with comprehensive test coverage, follows existing code patterns, maintains backward compatibility, and addresses a specific bug without introducing new complexity
• No files require special attention

Important Files Changed

Filename	Overview
apps/sim/lib/workflows/comparison/normalize.ts	Added sanitizeVariable to remove UI-only validationError field and normalizeVariables to handle legacy empty array format
apps/sim/lib/workflows/comparison/compare.ts	Updated variable comparison to normalize variables and sanitize before comparison, preventing false change detection
apps/sim/lib/workflows/comparison/compare.test.ts	Added comprehensive test coverage for variable comparison edge cases including validation errors and empty array handling

Sequence Diagram

sequenceDiagram
participant Client as hasWorkflowChanged
participant Norm as normalizeVariables
participant San as sanitizeVariable
participant Comp as normalizeValue
Note over Client: Compare current vs deployed state
Client->>Norm: normalizeVariables(currentState.variables)
alt variables is null/undefined
Norm-->>Client: {}
else variables is Array
Norm-->>Client: {} (legacy format)
else variables is object
Norm-->>Client: variables
end
Client->>Norm: normalizeVariables(deployedState.variables)
Norm-->>Client: normalized variables
Note over Client: Sanitize each variable
loop For each variable
Client->>San: sanitizeVariable(variable)
San-->>Client: variable without validationError
end
Client->>Comp: normalizeValue(sanitized variables)
Comp-->>Client: normalized for comparison
Note over Client: Compare stringified normalized values
alt Values differ
Client-->>Client: return true (changed)
else Values same
Client-->>Client: return false (unchanged)
end

Loading