Skip to content

fix(jsm): renamed operation - #2651

Merged
aadamgough merged 2 commits into
stagingfrom
fix/jsm-op
Dec 31, 2025
Merged

fix(jsm): renamed operation#2651
aadamgough merged 2 commits into
stagingfrom
fix/jsm-op

Conversation

@aadamgough

Copy link
Copy Markdown
Contributor

Summary

Renamed operation to shorten it

Type of Change

  • Bug fix

Testing

Manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercelBot commented Dec 31, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentReviewUpdated (UTC)
docsReadyReadyPreview, CommentDec 31, 2025 8:06am

@greptile-apps

Copy link
Copy Markdown
Contributor

Greptile Summary

Renamed JSM operation from jsm_add_organization_to_service_desk to shorter jsm_add_organization across tool definitions, type declarations, block configs, registry, and English documentation.

  • Renamed tool file from add_organization_to_service_desk.ts to add_organization.ts
  • Updated tool ID, name, and all type references (JsmAddOrganizationToServiceDesk*JsmAddOrganization*)
  • Updated block operation ID from add_organization_to_service_desk to add_organization
  • Updated tool registry mapping
  • Updated English documentation
  • Unrelated SpotifyIcon change included (simplified SVG implementation)
  • Internationalized documentation files (zh, ja, fr, es, de) still reference old operation name

Confidence Score: 4/5

  • This PR is safe to merge with minor concerns about completeness
  • The rename is consistently applied across all core code files (tool, types, registry, block config), but internationalized documentation was not updated and an unrelated icon change was included. These issues don't affect functionality but reduce completeness.
  • Check apps/docs/content/docs/{zh,ja,fr,es,de}/tools/jira_service_management.mdx for missed updates

Important Files Changed

FilenameOverview
apps/docs/components/icons.tsxUnrelated Spotify icon change included in PR
apps/docs/content/docs/en/tools/jira_service_management.mdxUpdated documentation to reflect renamed operation from jsm_add_organization_to_service_desk to jsm_add_organization
apps/sim/blocks/blocks/jira_service_management.tsUpdated block config with renamed operation ID and label
apps/sim/tools/jsm/add_organization.tsRenamed file and exports from add_organization_to_service_desk to add_organization

Sequence Diagram

sequenceDiagram
participant User
participant Block as JiraServiceManagementBlock
participant Registry as Tool Registry
participant Tool as jsmAddOrganizationTool
participant API as JSM API
User->>Block: Select "Add Organization" operation
Block->>Block: Map operation to tool ID
Note over Block: "add_organization" → "jsm_add_organization"
Block->>Registry: Lookup tool by ID
Registry->>Tool: Return jsmAddOrganizationTool
Tool->>API: POST /api/tools/jsm/organization
Note over API: action: "add_to_service_desk"
API-->>Tool: Response with success status
Tool-->>Block: JsmAddOrganizationResponse
Block-->>User: Display result
Loading

@greptile-appsgreptile-appsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

Comment threadapps/docs/components/icons.tsx Outdated
Comment on lines 4287 to 4295
<svg {...props} xmlns='http://www.w3.org/2000/svg' viewBox='0 0 496 512'>
<path
fill='#1ed760'
d='M248 8C111.1 8 0 119.1 0 256s111.1 248 248 248 248-111.1 248-248S384.9 8 248 8Z'
/>
<path d='M406.6 231.1c-5.2 0-8.4-1.3-12.9-3.9-71.2-42.5-198.5-52.7-280.9-29.7-3.6 1-8.1 2.6-12.9 2.6-13.2 0-23.3-10.3-23.3-23.6 0-13.6 8.4-21.3 17.4-23.9 35.2-10.3 74.6-15.2 117.5-15.2 73 0 149.5 15.2 205.4 47.8 7.8 4.5 12.9 10.7 12.9 22.6 0 13.6-11 23.3-23.2 23.3zm-31 76.2c-5.2 0-8.7-2.3-12.3-4.2-62.5-37-155.7-51.9-238.6-29.4-4.8 1.3-7.4 2.6-11.9 2.6-10.7 0-19.4-8.7-19.4-19.4s5.2-17.8 15.5-20.7c27.8-7.8 56.2-13.6 97.8-13.6 64.9 0 127.6 16.1 177 45.5 8.1 4.8 11.3 11 11.3 19.7-.1 10.8-8.5 19.5-19.4 19.5zm-26.9 65.6c-4.2 0-6.8-1.3-10.7-3.6-62.4-37.6-135-39.2-206.7-24.5-3.9 1-9 2.6-11.9 2.6-9.7 0-15.8-7.7-15.8-15.8 0-10.3 6.1-15.2 13.6-16.8 81.9-18.1 165.6-16.5 237 26.2 6.1 3.9 9.7 7.4 9.7 16.5s-7.1 15.4-15.2 15.4z' />
</svg>
)
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: unrelated change to SpotifyIcon included in PR about renaming JSM operation

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/docs/components/icons.tsx
Line: 4287:4295
Comment:
**style:** unrelated change to `SpotifyIcon` included in PR about renaming JSM operation
How can I resolve this? If you propose a fix, please make it concise.

| `success` | boolean | Whether the operation succeeded |

### `jsm_add_organization_to_service_desk`
### `jsm_add_organization`

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: check that internationalized docs (zh, ja, fr, es, de) are updated - they still reference jsm_add_organization_to_service_desk

Prompt To Fix With AI
This is a comment left during a code review.
Path: apps/docs/content/docs/en/tools/jira_service_management.mdx
Line: 278:278
Comment:
**style:** check that internationalized docs (zh, ja, fr, es, de) are updated - they still reference `jsm_add_organization_to_service_desk`
How can I resolve this? If you propose a fix, please make it concise.

@aadamgough
aadamgough merged commit fb148c6 into stagingDec 31, 2025
10 checks passed
@aadamgough
aadamgough deleted the fix/jsm-op branch December 31, 2025 08:08
Sg312 pushed a commit that referenced this pull request Jan 3, 2026
* renamed operaiton
* revert icons file
waleedlatif1 pushed a commit that referenced this pull request Jan 8, 2026
* renamed operaiton
* revert icons file
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@aadamgough