Skip to content

improvement(skills): extend skills - #3035

Merged
waleedlatif1 merged 1 commit into
stagingfrom
improvement/skills
Jan 28, 2026
Merged

improvement(skills): extend skills#3035
waleedlatif1 merged 1 commit into
stagingfrom
improvement/skills

Conversation

@waleedlatif1

Copy link
Copy Markdown
Collaborator

Summary

  • extend skills

Type of Change

  • Bug fix

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercelBot commented Jan 28, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

ProjectDeploymentReviewUpdated (UTC)
docsReadyReadyPreview, CommentJan 28, 2026 1:42am

Request Review

@greptile-apps

Copy link
Copy Markdown
Contributor

Greptile Overview

Greptile Summary

Improved the add-tools skill documentation by clarifying when to use each parameter visibility option. The changes add helpful inline comments and expand descriptions to guide developers on proper usage patterns.

Key improvements:

  • Clarified that hidden visibility should only be used for OAuth accessToken parameters (system-injected)
  • Explicitly added "api key" to the user-only visibility description alongside credentials and IDs
  • Updated user-or-llm description to indicate "everything else" falls into this category for better clarity
  • Added consistent guidance that aligns with the existing codebase patterns (e.g., Ahrefs tools use user-only for API keys)

The documentation changes are purely additive clarifications that help prevent misuse of the hidden visibility parameter, which should be reserved for OAuth tokens only.

Confidence Score: 5/5

  • Safe to merge - documentation-only improvements with no code changes
  • The PR only modifies documentation to add clarifying comments about parameter visibility usage. The changes align with existing best practices in the codebase and provide helpful guidance to prevent future misuse of visibility options.
  • No files require special attention

Important Files Changed

FilenameOverview
.claude/commands/add-tools.mdClarified visibility parameter usage guidelines with helpful inline comments

Sequence Diagram

sequenceDiagram
participant Dev as Developer
participant Skill as Add-Tools Skill
participant API as API Documentation
participant Code as Codebase
Dev->>Skill: Request to create tool integration
Skill->>API: Fetch API documentation
API-->>Skill: Return API specs
Skill->>Skill: Analyze parameter types
Note over Skill: Apply visibility rules:<br/>- hidden: OAuth accessToken only<br/>- user-only: API keys, credentials<br/>- user-or-llm: Everything else
Skill->>Code: Generate tool configuration
Note over Code: params with correct<br/>visibility settings
Skill->>Code: Generate types.ts
Skill->>Code: Generate index.ts
Skill->>Code: Register in registry.ts
Code-->>Dev: Tool integration complete
Loading

@greptile-appsgreptile-appsBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@waleedlatif1
waleedlatif1 merged commit 20b76e6 into stagingJan 28, 2026
12 checks passed
@waleedlatif1
waleedlatif1 deleted the improvement/skills branch January 28, 2026 02:30
royceP2 pushed a commit to arenadeveloper02/p2-sim that referenced this pull request Mar 3, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@waleedlatif1