Uh oh!
There was an error while loading. Please reload this page.
improvement(function): timeout increase to 5 min - #3040
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. |
Uh oh!
There was an error while loading. Please reload this page.
Greptile OverviewGreptile SummaryThis PR increases the fetch timeout within the isolated VM worker from 30 seconds to 5 minutes. This change allows user code executing in the isolated VM to make longer-running HTTP requests without timing out. Key Changes:
Context: Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Parent as Parent Process<br/>(isolated-vm.ts)
participant Worker as Worker Process<br/>(isolated-vm-worker.cjs)
participant IVM as Isolated VM Context
participant UserCode as User Code
Parent->>Worker: execute request (timeoutMs)
activate Worker
Note over Parent: Parent timeout = timeoutMs + 1s
Worker->>IVM: Create isolate & context
Worker->>IVM: Inject fetch callback
IVM->>UserCode: Run user code (timeoutMs)
activate UserCode
UserCode->>IVM: Call fetch(url, options)
IVM->>Worker: __fetchRef callback
Worker->>Parent: IPC fetch request
Note over Worker: FETCH_TIMEOUT_MS = 5 min
Parent->>Parent: secureFetch (validate URL)
Parent->>Parent: Execute fetch
Parent-->>Worker: IPC fetch response
Worker-->>IVM: Resolve fetch promise
IVM-->>UserCode: Return response
alt Fetch times out (> 5 min)
Worker-->>IVM: Timeout error
IVM-->>UserCode: Throw error
end
UserCode-->>IVM: Return result
deactivate UserCode
IVM-->>Worker: Execution complete
Worker-->>Parent: IPC result
deactivate Worker
|
Summary
Increase isolated worker timeout to 5 min.
Type of Change
Testing
Tested manually
Checklist