fix(tag-dropdown): exclude downstream blocks in loops and parallel siblings by waleedlatif1 · Pull Request #3312 · simstudioai/sim

waleedlatif1 · 2026-02-23T21:34:50Z

Summary

Fixed tag dropdown (< reference picker) showing downstream blocks when editing a block inside a loop
Loop nodes are now filtered to only include blocks that are genuinely upstream (already in ancestorIds)
Parallel sibling nodes are excluded entirely — they run simultaneously, not before the current block

Type of Change

Bug fix

Testing

Tested manually

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

…blings from reference picker

vercel · 2026-02-23T21:34:55Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Feb 23, 2026 10:15pm

greptile-apps · 2026-02-23T21:38:25Z

Greptile Summary

Fixes tag dropdown to exclude downstream blocks in loops and parallel siblings. Previously, blocks inside loops could reference downstream blocks in the same loop, and blocks inside parallels could reference sibling blocks that run simultaneously. The fix consistently applies across both frontend tag picker and copilot tools by only adding loop/parallel container IDs rather than all child nodes. Also removes unused accessibleBlocksMap calculation from serializer and calculateAccessibleBlocksForWorkflow from block path calculator.

Confidence Score: 5/5

Safe to merge - focused bug fix with consistent logic across frontend and backend
Clean refactor that removes genuinely unused code and fixes a logical bug where downstream/parallel blocks were incorrectly accessible. Changes are consistent across both frontend and backend codepaths.
No files require special attention

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-accessible-reference-prefixes.ts	Correctly removes downstream loop/parallel nodes from accessible references, only adds container IDs
apps/sim/lib/copilot/orchestrator/tool-executor/workflow-tools/queries.ts	Applies same fix to copilot tool - only adds loop/parallel container IDs, not child nodes

_{Last reviewed commit: f31ac10}

greptile-apps

_{1 file reviewed, 2 comments}

_{Edit Code Review Agent Settings | Greptile}

waleedlatif1 · 2026-02-23T21:40:42Z

@greptile

waleedlatif1 · 2026-02-23T21:40:47Z

@cursor review

greptile-apps

_{2 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

…ForWorkflow method

waleedlatif1 · 2026-02-23T21:46:14Z

@cursor review

waleedlatif1 · 2026-02-23T21:48:07Z

@cursor review

waleedlatif1 · 2026-02-23T21:48:11Z

@greptile

greptile-apps

_{3 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

…es in parallel branches

waleedlatif1 · 2026-02-23T21:53:50Z

@cursor review

waleedlatif1 · 2026-02-23T21:59:19Z

@cursor review

…s for blocks inside parallel

waleedlatif1 · 2026-02-23T22:09:37Z

@cursor review

waleedlatif1 · 2026-02-23T22:09:41Z

@greptile

greptile-apps

_{3 files reviewed, 1 comment}

_{Edit Code Review Agent Settings | Greptile}

…m accessible references

waleedlatif1 · 2026-02-23T22:15:40Z

@greptile

waleedlatif1 · 2026-02-23T22:15:44Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

greptile-apps

_{4 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

…blings (simstudioai#3312) * fix(tag-dropdown): exclude downstream blocks in loops and parallel siblings from reference picker * chore(serializer): remove unused computeAccessibleBlockIds method * chore(block-path-calculator): remove unused calculateAccessibleBlocksForWorkflow method * chore(tag-dropdown): remove no-op loop node filter * fix(tag-dropdown): remove parallel container from accessible references in parallel branches * chore(tag-dropdown): remove no-op starter block filter * fix(tag-dropdown): restore parallel container in accessible references for blocks inside parallel * fix(copilot): exclude downstream loop nodes and parallel siblings from accessible references

fix(tag-dropdown): exclude downstream blocks in loops and parallel si…
019b407
…blings from reference picker

waleedlatif1 changed the title ~~fix(tag-dropdown): exclude downstream blocks in loops and parallel siblings from reference picker~~fix(tag-dropdown): exclude downstream blocks in loops and parallel siblingsFeb 23, 2026

greptile-appsBot reviewed Feb 23, 2026
View reviewed changes

Comment threadapps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-accessible-reference-prefixes.ts Outdated
Comment threadapps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-accessible-reference-prefixes.ts Outdated

chore(serializer): remove unused computeAccessibleBlockIds method
0c261f7

vercelBottemporarily deployed to Preview February 23, 2026 21:40 Inactive

greptile-appsBot reviewed Feb 23, 2026
View reviewed changes

chore(block-path-calculator): remove unused calculateAccessibleBlocks…
f7404a3
…ForWorkflow method

vercelBottemporarily deployed to Preview February 23, 2026 21:45 Inactive

cursorBot reviewed Feb 23, 2026
View reviewed changes

Comment threadapps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-accessible-reference-prefixes.ts Outdated

chore(tag-dropdown): remove no-op loop node filter
b068b42

vercelBottemporarily deployed to Preview February 23, 2026 21:47 Inactive

cursorBot reviewed Feb 23, 2026
View reviewed changes

Comment threadapps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-accessible-reference-prefixes.ts Outdated

cursorBot reviewed Feb 23, 2026
View reviewed changes

Comment threadapps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-accessible-reference-prefixes.ts

greptile-appsBot reviewed Feb 23, 2026
View reviewed changes

fix(tag-dropdown): remove parallel container from accessible referenc…
a44e766
…es in parallel branches

vercelBottemporarily deployed to Preview February 23, 2026 21:53 Inactive

chore(tag-dropdown): remove no-op starter block filter
68bc9f6

vercelBottemporarily deployed to Preview February 23, 2026 21:57 Inactive

cursorBot reviewed Feb 23, 2026
View reviewed changes

Comment threadapps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-accessible-reference-prefixes.ts

cursorBot reviewed Feb 23, 2026
View reviewed changes

Comment threadapps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-accessible-reference-prefixes.ts

fix(tag-dropdown): restore parallel container in accessible reference…
de8ef28
…s for blocks inside parallel

vercelBottemporarily deployed to Preview February 23, 2026 22:07 Inactive

greptile-appsBot reviewed Feb 23, 2026
View reviewed changes

Comment threadapps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-accessible-reference-prefixes.ts

fix(copilot): exclude downstream loop nodes and parallel siblings fro…
f31ac10
…m accessible references

vercelBottemporarily deployed to Preview February 23, 2026 22:15 Inactive

cursorBot reviewed Feb 23, 2026
View reviewed changes

greptile-appsBot reviewed Feb 23, 2026
View reviewed changes

cursorBot reviewed Feb 23, 2026
View reviewed changes

waleedlatif1 merged commit eafbb9f into stagingFeb 23, 2026
12 checks passed

waleedlatif1 deleted the fix/tag-dropdown branch February 23, 2026 22:21

waleedlatif1 mentioned this pull request Feb 24, 2026
v0.5.100: multiple credentials, 40% speedup, gong, attio, audit log improvements #3326
Merged

Uh oh!

Conversation

waleedlatif1 commented Feb 23, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercelBot commented Feb 23, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

greptile-appsBot commented Feb 23, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

greptile-appsBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Feb 23, 2026

Uh oh!

waleedlatif1 commented Feb 23, 2026

Uh oh!

greptile-appsBot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Feb 23, 2026

Uh oh!

Uh oh!

waleedlatif1 commented Feb 23, 2026

Uh oh!

Uh oh!

waleedlatif1 commented Feb 23, 2026

Uh oh!

Uh oh!

greptile-appsBot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented Feb 23, 2026

Uh oh!

waleedlatif1 commented Feb 23, 2026

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented Feb 23, 2026

Uh oh!

waleedlatif1 commented Feb 23, 2026

Uh oh!

greptile-appsBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

waleedlatif1 commented Feb 23, 2026

Uh oh!

waleedlatif1 commented Feb 23, 2026

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

greptile-appsBot left a comment

Choose a reason for hiding this comment

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercelBot commented Feb 23, 2026•
edited
Loading

greptile-appsBot commented Feb 23, 2026•
edited
Loading