fix(autolayout): edits coalesced for same request diffs

[icecrasher321]

Summary

Need to identify targetted autlayout targets more intelligently.

Type of Change

• Bug fix

Testing

Tested manually

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[cursor]

PR Summary

Medium Risk
Changes the logic that decides which workflow blocks get repositioned and adds a new shifting path for downstream blocks, which can subtly affect many layouts. Risk is mitigated by new unit tests covering edge/position and scope cases.

Overview
Improves targeted autolayout triggering by replacing ad-hoc “blocks needing layout” detection with a shared getTargetedLayoutImpact(before, after) change-set that accounts for new blocks with sentinel/invalid positions, parent-scope moves, and newly added edges (within the same parent scope).

Extends applyTargetedLayout to accept shiftSourceBlockIds, enabling edits that only add connections to shift downstream frozen blocks without relaying out anchors; both the server edit_workflow tool and the client WorkflowDiffEngine now use this impact to decide when to run targeted layout.

Adds focused Vitest coverage for the new change-set and shift behavior, including hyphenated handles/ids and cross-scope edge changes.

^{Written by Cursor Bugbot for commit adc5cee. Configure here.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Mar 23, 2026 11:34pm

[greptile-apps]

Greptile Summary

This PR refactors how autolayout determines which blocks need repositioning after a copilot edit, extracting the ad-hoc detection logic that was duplicated in edit-workflow/index.ts and diff-engine.ts into a dedicated change-set.ts module. The new getTargetedLayoutImpact function adds smarter edge-based detection: blocks that gain their first incoming edge are now scheduled for layout, and edge sources connecting to already-connected targets are tracked as shiftSourceBlockIds so they can trigger downstream positional shifts without forcing a full re-layout of stable blocks. The targeted.ts engine is updated to accept the new shiftSourceBlockIds and gate the layout computation and vertical-overlap resolution separately from the shift pass.

• New module change-set.ts: Centralises layout-impact detection, replacing two near-identical inline implementations. Detects three cases: new blocks, parent-changed blocks at (0,0), and blocks/edges that affect the DAG connection graph.
• shiftSourceBlockIds: New concept in TargetedLayoutOptions — blocks whose downstream frozen neighbours should be pushed rightward even when the source block itself does not need a fresh layout position.
• Edge-based detection in getTargetedLayoutImpact: Only added, same-scope edges (endpoints sharing a parent) are considered; cross-scope and removed edges are intentionally ignored.
• Broader (0,0) invalidation (getBlocksWithInvalidPositions): This helper now applies to all blocks in after, including pre-existing ones with unchanged parents — a wider trigger than the previous per-site logic that only applied the (0,0) check to new blocks or parent-changed blocks. This could unexpectedly re-layout blocks that were intentionally placed at the canvas origin.
• Edge signature collision: The getEdgeSignature helper uses - as the field separator, which also appears in UUID block IDs and some handle names (e.g. loop-start-source), creating a theoretical (though low-probability) false-match that could suppress a needed layout pass.
• Missing test for pure-shift path: The test suite covers the case where a block is in both layoutBlockIds and shiftSourceBlockIds, but not the case where it is only in shiftSourceBlockIds (an existing, already-connected block gains a new outgoing edge to another already-connected block).

Confidence Score: 4/5

• Safe to merge with one concrete fix recommended for the edge-signature delimiter before it can cause a silent layout miss.
• The core logic is sound, well-structured, and backed by meaningful tests. The extraction into change-set.ts removes duplication and the edge-based detection addresses the coalesced-edit problem cleanly. The P1 edge-signature collision is low-probability in practice (UUID separators vs. handle name separators are different), but it is a correctness hazard worth fixing. The broader getBlocksWithInvalidPositions scope is a notable behavioral change worth the author confirming as intentional.
• apps/sim/lib/workflows/autolayout/change-set.ts — edge-signature delimiter and broad (0,0) invalidation scope

Important Files Changed

Filename	Overview
apps/sim/lib/workflows/autolayout/change-set.ts	New module extracting layout-impact detection. Key concern: getBlocksWithInvalidPositions is applied to all blocks (not just new/parent-changed ones), broadening the layout trigger compared to prior behavior. Edge signature also uses - as delimiter which could theoretically collide with UUIDs and hyphenated handle names.
apps/sim/lib/workflows/autolayout/change-set.test.ts	Good coverage of new-block, subblock-only, edge-added, and cross-scope scenarios. Missing a test for the pure shift-source-only code path (existing connected block gaining a new edge to another already-connected block).
apps/sim/lib/workflows/autolayout/targeted.ts	Correctly gates layout computation behind needsLayout.length > 0 while always running shiftDownstreamFrozenBlocks when activeShiftSourceSet is non-empty. Skipping resolveVerticalOverlapsWithFrozen when needsLayout.length === 0 is safe since that function only moves blocks already in needsLayoutSet.
apps/sim/lib/copilot/tools/server/workflow/edit-workflow/index.ts	Clean replacement of the inline block-detection logic with getTargetedLayoutImpact. The new shiftSourceBlockIds is correctly threaded into applyTargetedLayout.
apps/sim/lib/workflows/diff/diff-engine.ts	Inline detection replaced with getTargetedLayoutImpact. Impact analysis uses fullyCleanedState while layout is applied to finalBlocks; since fullyCleanedState = finalProposedState (line 486) these resolve to the same workflow state, so there is no divergence. Log field renamed from blocksNeedingLayout count to include shiftSourceBlocks.
apps/sim/lib/workflows/diff/diff-engine.test.ts	Mock updated to include getTargetedLayoutImpact with a no-op return, correctly preventing any layout side-effects during unit tests.
apps/sim/lib/workflows/autolayout/index.ts	Re-exports getTargetedLayoutChangeSet and getTargetedLayoutImpact from the new change-set module. Uses established path-alias pattern (@/lib/...).

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[getTargetedLayoutImpact] --> B{New block?}
B -- Yes --> C[Add to layoutBlockIds]
B -- No --> D{Parent changed + pos 0,0?}
D -- Yes --> C
D -- No --> E[skip]
A --> F[getBlocksWithInvalidPositions - all after blocks]
F -- invalid or 0,0 --> C
A --> G[getAddedLayoutScopedEdges]
G -- no new edges --> H[Return: layoutBlockIds + shiftSourceBlockIds empty]
G -- new edges --> I{Target gained first incoming edge?}
I -- Yes --> C
I -- No --> J[Add source to shiftSourceBlockIds]
C --> K[applyTargetedLayout]
J --> K
K --> L{needsLayout more than 0?}
L -- Yes --> M[computeLayoutPositions + apply offsets to needsLayout blocks]
L -- No --> N[skip layout computation]
M --> O[shiftDownstreamFrozenBlocks BFS from activeShiftSourceSet]
N --> O
O --> P{needsLayout more than 0?}
P -- Yes --> Q[resolveVerticalOverlapsWithFrozen]
P -- No --> R[Done]
Q --> R

Loading

_{Reviews (1): Last reviewed commit: "fix(autolayout): edits coalesced for sam..." | Re-trigger Greptile}

[icecrasher321]

bugbot run

[icecrasher321]

bugbot run

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR