Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 3.8k
fix(copilot): expand tool metadata, fix thinking text rendering, clean up display logic#3779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
dc086b0
fix(copilot): expand tool metadata, fix thinking text rendering, clea…
waleedlatif1 3464600
fix(copilot): guard null reasoning data, use ensureTextBlock for thin…
waleedlatif1 2f1c375
fix(copilot): restore displayTitle precedence so cancelled tools show…
waleedlatif1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
65 changes: 19 additions & 46 deletions
65 apps/sim/app/workspace/[workspaceId]/home/components/message-content/message-content.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
77 changes: 68 additions & 9 deletions
77 apps/sim/app/workspace/[workspaceId]/home/components/message-content/utils.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
37 changes: 37 additions & 0 deletions
37 apps/sim/app/workspace/[workspaceId]/home/hooks/use-chat.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -166,6 +166,13 @@ function buildReplayStream(events: StreamEventEnvelope[]): ReadableStream<Uint8A | ||
| } | ||
| function mapStoredBlock(block: TaskStoredContentBlock): ContentBlock { | ||
| if (block.type === 'thinking') { | ||
| return { | ||
| type: 'text', | ||
| content: block.content ? `<thinking>${block.content}</thinking>` : '', | ||
| } | ||
| } | ||
| const mapped: ContentBlock = { | ||
| type: block.type as ContentBlockType, | ||
| content: block.content, | ||
| @@ -1078,6 +1085,36 @@ export function useChat( | ||
| } | ||
| break | ||
| } | ||
| case 'reasoning': { | ||
| const d = ( | ||
| parsed.data && typeof parsed.data === 'object' ? parsed.data : {} | ||
| ) as Record<string, unknown> | ||
| const phase = d.phase as string | undefined | ||
| if (phase === 'start') { | ||
| const tb = ensureTextBlock() | ||
| tb.content = `${tb.content ?? ''}<thinking>` | ||
| runningText += '<thinking>' | ||
| streamingContentRef.current = runningText | ||
| flush() | ||
| } else if (phase === 'end') { | ||
| const tb = ensureTextBlock() | ||
| tb.content = `${tb.content ?? ''}</thinking>` | ||
| runningText += '</thinking>' | ||
| streamingContentRef.current = runningText | ||
| flush() | ||
| } else { | ||
waleedlatif1 marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| const chunk = | ||
| typeof d.data === 'string' ? d.data : (parsed.content as string | undefined) | ||
| if (chunk) { | ||
| const tb = ensureTextBlock() | ||
| tb.content = (tb.content ?? '') + chunk | ||
| runningText += chunk | ||
| streamingContentRef.current = runningText | ||
| flush() | ||
| } | ||
| } | ||
| break | ||
| } | ||
| case 'tool_generating': | ||
| case 'tool_call': { | ||
| const id = parsed.toolCallId | ||
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.