Skip to content

fix(knowledge): show spinner on connector chip while syncing#3808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 2 commits into from
Mar 27, 2026
Merged

fix(knowledge): show spinner on connector chip while syncing #3808

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f65c2d
fix(knowledge): show spinner on connector chip while syncing
waleedlatif1 Mar 27, 2026
559ad58
fix(knowledge): scope sync spinner to mutation lifetime, not cooldown
waleedlatif1 Mar 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions ...rkspace/[workspaceId]/knowledge/[id]/components/connectors-section/connectors-section.tsx
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -79,6 +79,7 @@ export function ConnectorsSection({
const [deleteTarget, setDeleteTarget] = useState<string | null>(null)
const [editingConnector, setEditingConnector] = useState<ConnectorData | null>(null)
const [error, setError] = useState<string | null>(null)
const [syncingConnectorId, setSyncingConnectorId] = useState<string | null>(null)

const syncTriggeredAt = useRef<Record<string, number>>({})
const cooldownTimers = useRef<Set<ReturnType<typeof setTimeout>>>(new Set())
Expand All@@ -103,12 +104,14 @@ export function ConnectorsSection({
if (isSyncOnCooldown(connectorId)) return

syncTriggeredAt.current[connectorId] = Date.now()
setSyncingConnectorId(connectorId)

triggerSync(
{ knowledgeBaseId, connectorId },
{
onSuccess: () => {
setError(null)
setSyncingConnectorId(null)
const timer = setTimeout(() => {
cooldownTimers.current.delete(timer)
forceUpdate((n) => n + 1)
Expand All@@ -118,6 +121,7 @@ export function ConnectorsSection({
onError: (err) => {
logger.error('Sync trigger failed', { error: err.message })
setError(err.message)
setSyncingConnectorId(null)
delete syncTriggeredAt.current[connectorId]
forceUpdate((n) => n + 1)
},
Expand DownExpand Up@@ -164,6 +168,7 @@ export function ConnectorsSection({
knowledgeBaseId={knowledgeBaseId}
canEdit={canEdit}
isSyncing={isSyncing}
isSyncPending={syncingConnectorId === connector.id}
isUpdating={isUpdating}
syncCooldown={isSyncOnCooldown(connector.id)}
onSync={() => handleSync(connector.id)}
Expand DownExpand Up@@ -251,6 +256,7 @@ interface ConnectorCardProps {
knowledgeBaseId: string
canEdit: boolean
isSyncing: boolean
isSyncPending: boolean
isUpdating: boolean
syncCooldown: boolean
onSync: () => void
Expand All@@ -265,6 +271,7 @@ function ConnectorCard({
knowledgeBaseId,
canEdit,
isSyncing,
isSyncPending,
isUpdating,
syncCooldown,
onSync,
Expand DownExpand Up@@ -306,13 +313,13 @@ function ConnectorCard({
{Icon && <Icon className='h-5 w-5 flex-shrink-0' />}
<div className='flex flex-col gap-0.5'>
<div className='flex items-center gap-2'>
<span className='font-medium text-[var(--text-primary)] text-small'>
<span className='flex items-center gap-1.5 font-medium text-[var(--text-primary)] text-small'>
{connectorDef?.name || connector.connectorType}
{(isSyncPending || connector.status === 'syncing') && (
<Loader2 className='h-3 w-3 animate-spin text-[var(--text-muted)]' />
)}
Comment thread
waleedlatif1 marked this conversation as resolved.
</span>
<Badge variant={statusConfig.variant} className='text-micro'>
{connector.status === 'syncing' && (
<Loader2 className='mr-1 h-3 w-3 animate-spin' />
)}
{statusConfig.label}
</Badge>
</div>
Expand Down
Loading