chore(stores): remove Zustand environment store and dead init scaffolding

[waleedlatif1]

Summary

• Removed useEnvironmentStore Zustand store — env vars now read exclusively from React Query cache
• Stripped stores/variables to UI-only (modal position/dimensions) — variable data already lives in stores/panel/variables
• Removed dead loadForWorkflow from panel variables store (hydrated by registry, never called externally)
• Cleaned up stores/index.ts: removed empty initializeApplication(), useAppInitialization, reinitializeAfterLogin, logAllStores, and all dead init flags/hooks
• Removed dead getStore test injection parameter from getClientEnvVars / createCustomToolRequestBody

Type of Change

• Refactoring (internal cleanup, zero behavior change)

Testing

• TypeScript compiles clean
• All 34 utils tests pass
• Lint passes
• Server-side execution loads env vars from DB directly (unchanged)
• Client-side env var resolution reads from same React Query cache that usePersonalEnvironment() populates
• Logout clears env vars from RQ cache via removeQueries

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[cursor]

PR Summary

Medium Risk
Moderate refactor that changes the source of client-side environment variables (Zustand -> React Query cache) and rehomes variable types/state; main risk is missed cache hydration/clearing leading to missing env vars or stale UI state.

Overview
Removes the Zustand-backed useEnvironmentStore and switches client-side environment variable reads to come directly from the React Query cache (usePersonalEnvironment / environmentKeys.personal()), updating selector resolution and custom tool env-var injection accordingly.

Refactors the floating variables modal store (stores/variables) to be UI-only (position/size persistence) and relies on the panel variables store for variable data/types; also drops unused variable-loading APIs and simplifies logout/reset logic to clear env queries via removeQueries instead of resetting an env store.

^{Reviewed by Cursor Bugbot for commit b4bc112. Configure here.}

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Apr 4, 2026 0:45am

[greptile-apps]

Greptile Summary

This PR removes the useEnvironmentStore Zustand store and associated dead initialization scaffolding, consolidating environment variable access into the React Query cache (usePersonalEnvironment()) and cleaning up the stores/variables store to be UI-only (modal position/dimensions).

Key changes:

• stores/settings/environment/store.ts deleted — all env var reads now go through the React Query cache populated by usePersonalEnvironment()
• stores/variables/store.ts stripped to UI modal state only; variable CRUD moved entirely to stores/panel/variables/store.ts
• stores/index.ts cleaned of dead initializeApplication, useAppInitialization, reinitializeAfterLogin, logAllStores, and related init flags
• tools/utils.ts — getClientEnvVars now reads the RQ cache directly via getQueryClient(); removed dead getStore test-injection parameter
• hooks/queries/environment.ts — removed the useEffect that was syncing RQ data back into the Zustand store (now unnecessary)
• All call sites (use-selector-setup.ts, use-workflow-execution.ts, variables.tsx) updated to consume env vars / Variable types from their new canonical sources
• Tests updated to mock getQueryClient instead of the Zustand store, with all 34 tests passing

The codebase search confirms no remaining references to useEnvironmentStore, getAllVariables, or loadForWorkflow.

Confidence Score: 5/5

Safe to merge — pure dead-code removal and store consolidation with zero behavior change.

All 15 changed files are internal refactors with no API-surface or data-flow changes. Exhaustive grep confirms no remaining uses of the removed store exports, methods, or scaffolding. The single finding (dead workflowId variable in deleteVariable) is a trivial P2 style nit that does not affect correctness.

No files require special attention.

Important Files Changed

Filename	Overview
apps/sim/hooks/queries/environment.ts	Removed the useEffect that synced React Query results back into the Zustand environment store, completing the migration to RQ as the sole source of truth for env vars.
apps/sim/stores/index.ts	Dead init scaffolding (initializeApplication, useAppInitialization, reinitializeAfterLogin, logAllStores) removed; only resetAllStores and clearUserData remain.
apps/sim/stores/variables/store.ts	Stripped to a pure UI modal-state store (position, width, height); all variable CRUD logic moved to stores/panel/variables/store.ts.
apps/sim/stores/panel/variables/store.ts	Now holds all variable CRUD (addVariable, updateVariable, deleteVariable, getVariablesByWorkflowId). Minor dead variable in deleteVariable (workflowId assigned but unused).
apps/sim/tools/utils.ts	getClientEnvVars now reads directly from React Query cache via getQueryClient(); removed dead getStore test-injection parameter from both getClientEnvVars and createCustomToolRequestBody.
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/hooks/use-workflow-execution.ts	Removed getAllVariables from useEnvironmentStore; env var resolution for execution now flows through getClientEnvVars() reading from the React Query cache.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Component / Hook] -->|before| B[useEnvironmentStore\nZustand]
A -->|after| C[usePersonalEnvironment\nReact Query]
B -->|synced via useEffect| C
C -->|reads| D[React Query Cache\nenvironmentKeys.personal]
D -->|populated by| E[fetchPersonalEnvironment\nAPI]
F[getClientEnvVars\ntools/utils.ts] -->|reads| D
G[resetAllStores\nstores/index.ts] -->|removeQueries| D
H[stores/variables/store.ts] -->|now UI-only| I[Modal position\n& dimensions]
J[stores/panel/variables/store.ts] -->|holds all| K[Variable CRUD\naddVariable / updateVariable / deleteVariable]

Loading

_{Reviews (2): Last reviewed commit: "chore(stores): remove Zustand environmen..." | Re-trigger Greptile}

[waleedlatif1]

@greptile

[waleedlatif1]

@cursor review

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit b4bc112. Configure here.}