Uh oh!
There was an error while loading. Please reload this page.
feat(auth): add DISABLE_GOOGLE_AUTH and DISABLE_GITHUB_AUTH env vars - #4019
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview Updates auth setup to conditionally register Reviewed by Cursor Bugbot for commit 02d3c2a. Configure here. |
Uh oh!
There was an error while loading. Please reload this page.
Greptile SummaryThis PR adds
Confidence Score: 5/5Safe to merge — implementation is correct, consistent with existing patterns, and introduces no regressions. All changes follow the established DISABLE_ flag pattern (z.boolean().optional() + isTruthy()). The conditional spread in auth.ts is safe JavaScript. The oauth-provider-checker correctly AND-gates credentials and the new flags. No P0 or P1 issues found. No files require special attention — all changes are clean and consistent. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A([User requests login page]) --> B[getOAuthProviderStatus called server-side]
B --> C{GITHUB credentials set?}
C -- No --> D[githubAvailable = false]
C -- Yes --> E{isGithubAuthDisabled?}
E -- Yes --> D
E -- No --> F[githubAvailable = true]
B --> G{GOOGLE credentials set?}
G -- No --> H[googleAvailable = false]
G -- Yes --> I{isGoogleAuthDisabled?}
I -- Yes --> H
I -- No --> J[googleAvailable = true]
D & F --> K[Return provider status]
H & J --> K
K --> L[OAuthProviderChecker renders]
L --> M{githubAvailable?}
M -- Yes --> N[Render GitHub login button]
M -- No --> O[Hide GitHub login button]
L --> P{googleAvailable?}
P -- Yes --> Q[Render Google login button]
P -- No --> R[Hide Google login button]
subgraph auth_init[auth.ts Initialization]
S([auth.ts loads]) --> T{isGithubAuthDisabled?}
T -- No --> U[Register GitHub social provider]
T -- Yes --> V[Skip GitHub provider]
S --> W{isGoogleAuthDisabled?}
W -- No --> X[Register Google social provider]
W -- Yes --> Y[Skip Google provider]
end
Reviews (3): Last reviewed commit: "lint" | Re-trigger Greptile |
waleedlatif1
commented
Apr 7, 2026
waleedlatif1
commented
Apr 7, 2026
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 02d3c2a. Configure here.
waleedlatif1
commented
Apr 7, 2026
waleedlatif1
commented
Apr 7, 2026
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 02d3c2a. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Summary
DISABLE_GOOGLE_AUTHandDISABLE_GITHUB_AUTHenv vars to explicitly hide OAuth login buttons even when credentials are configuredDISABLE_prefix convention withz.boolean()schema andisTruthyfeature flagsType of Change
Testing
Tested manually
Checklist