Skip to content

fix(docker): install devDeps in builder stage for build#4321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
waleedlatif1 wants to merge 1 commit into from
Closed

fix(docker): install devDeps in builder stage for build #4321

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docker/app.Dockerfile
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -80,6 +80,12 @@ COPY packages/workflow-authz/package.json ./packages/workflow-authz/package.json
COPY packages/workflow-persistence/package.json ./packages/workflow-persistence/package.json
COPY packages/workflow-types/package.json ./packages/workflow-types/package.json

# Install full dependency set. The deps stage installed --omit=dev for the
# runtime image; the build needs devDeps like tailwindcss/postcss. Placed
# before source copy so it stays cached on source-only changes.
RUN --mount=type=cache,id=bun-cache,target=/root/.bun/install/cache \
HUSKY=0 bun install --ignore-scripts --linker=hoisted
Comment on lines +86 to +87

@greptile-appsgreptile-appsBotApr 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2Consider adding --frozen-lockfile

Without --frozen-lockfile, if bun.lock is out of sync with a package.json entry, bun will silently update the lockfile inside the container — resulting in a different dependency tree than what was committed. The deps stage has the same omission, but since this install is the one that actually satisfies build-critical devDeps (tailwindcss, postcss), a version drift here would produce a hard-to-diagnose build failure. Adding the flag makes the build fully deterministic.

Suggested change
RUN --mount=type=cache,id=bun-cache,target=/root/.bun/install/cache \
HUSKY=0 bun install --ignore-scripts --linker=hoisted
HUSKY=0 bun install --frozen-lockfile --ignore-scripts --linker=hoisted


# Copy workspace configuration files (needed for turbo)
COPY apps/sim/next.config.ts ./apps/sim/next.config.ts
COPY apps/sim/tsconfig.json ./apps/sim/tsconfig.json
Expand Down
Loading