Uh oh!
There was an error while loading. Please reload this page.
improvement(sap_s4hana): use MERGE for OData v2 updates and enlarge icon - #4332
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR SummaryCursor Bugbot is generating a summary for commit 199fbff. Configure here. |
Greptile SummaryThis PR switches all 7 SAP S/4HANA update tools from Confidence Score: 4/5Safe to merge — targeted, low-risk changes with full proxy-layer support already in place All 7 tool changes are identical one-liners; the proxy already accepted MERGE before this PR. The viewBox crop is a straightforward visual adjustment mirrored correctly in both icon files. No automated tests were added (checkbox unchecked), keeping this below a perfect 5. No files require special attention Important Files Changed
Sequence DiagramsequenceDiagram
participant Tool as Update Tool<br/>(e.g. update_business_partner)
participant Proxy as SAP Proxy<br/>/api/tools/sap_s4hana/proxy
participant CSRF as SAP Metadata<br/>/$metadata
participant SAP as SAP OData v2<br/>Gateway
Tool->>Proxy: POST {method: "MERGE", path, body, ifMatch}
Proxy->>Proxy: Validate method in HttpMethod enum
Proxy->>CSRF: GET /$metadata (X-CSRF-Token: Fetch)
CSRF-->>Proxy: x-csrf-token + Set-Cookie
Proxy->>SAP: MERGE /A_BusinessPartner('123')<br/>If-Match: * | X-CSRF-Token: token
SAP-->>Proxy: 204 No Content
Proxy-->>Tool: {success: true, output: {status: 204, data: null}}
Reviews (1): Last reviewed commit: "improvement(sap_s4hana): use MERGE for O..." | Re-trigger Greptile |
Uh oh!
There was an error while loading. Please reload this page.
Summary
SapS4HanaIconviewBox so the logo renders slightly larger in block tiles (mirrored in docs icon set)Type of Change
Testing
Tested manually. Final validate-integration pass over all 38 tools + block + registries + proxy contract: 100% aligned with SAP API docs.
Checklist