fix(tasks): fix sidebar tasks skeleton hanging indefinitely

[waleedlatif1]

Summary

• Fix tasks list in sidebar showing loading skeleton forever instead of rendering tasks
• Root cause: tasksLoading was derived from fetchedTasks === undefined, which stays true forever on query errors or when workspaceId is temporarily absent
• Switch useTasks to use skipToken + placeholderData: keepPreviousData — matches the established useWorkflows/useWorkflowMap pattern
• Derive tasksLoading from isLoading (isPending && isFetching) instead of data presence — only true during an active first fetch with no cached data
• Add error logging via the existing logger so silent failures surface in logs

Type of Change

• Bug fix

Testing

Tested manually

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		Apr 30, 2026 9:43pm

[cursor]

PR Summary

Low Risk
Low risk UI/data-fetching tweak: switches task query enabling/loading logic to React Query primitives, which could slightly change caching/loading behavior but doesn’t touch auth or writes.

Overview
Fixes the sidebar tasks list getting stuck in a loading skeleton by basing tasksLoading on React Query’s isLoading instead of data === undefined.

Updates useTasks to use skipToken when workspaceId is missing and placeholderData: keepPreviousData, preventing indefinite loading on transient missing IDs and smoothing list transitions. Also adjusts Home’s empty-state gating to use showChatSkeleton rather than chatId directly so the greeting/input renders when chat history isn’t actively loading.

^{Reviewed by Cursor Bugbot for commit ef80370. Configure here.}

[greptile-apps]

Greptile Summary

Fixes the sidebar tasks skeleton hanging indefinitely by switching useTasks to skipToken + placeholderData: keepPreviousData and deriving tasksLoading from isLoading rather than data presence — matching the established useWorkflows/useWorkflowMap pattern. An additional undescribed change in home.tsx replaces the !chatId guard with !showChatSkeleton, so the welcome UI renders correctly when a chat resolves empty or in error.

Confidence Score: 5/5

Safe to merge — the fix is correct and scoped; the only open item is missing error logging described in the PR description.

All three changes are logically sound: skipToken correctly prevents isLoading from staying true indefinitely when workspaceId is absent, and the home.tsx guard change handles the loading edge case properly. No P0/P1 issues found.

No files require special attention beyond the missing error-logging follow-up in sidebar.tsx.

Important Files Changed

Filename	Overview
apps/sim/hooks/queries/tasks.ts	Switched useTasks to use skipToken (instead of enabled: Boolean(workspaceId)) and added placeholderData: keepPreviousData — correct pattern that prevents isLoading from hanging when workspaceId is absent.
apps/sim/app/workspace/[workspaceId]/w/components/sidebar/sidebar.tsx	Derives tasksLoading from isLoading (isPending && isFetching) instead of data presence — fixes the skeleton hanging indefinitely; error logging described in PR description was not added.
apps/sim/app/workspace/[workspaceId]/home/home.tsx	Changed welcome-UI guard from !chatId to !showChatSkeleton — shows the initial view when a chatId resolves with 0 messages or on error; change is logical but undescribed in the PR description.

Sequence Diagram

sequenceDiagram
participant Sidebar
participant useTasks
participant TanStackQuery
participant API
Note over Sidebar,API: Before fix
Sidebar->>useTasks: useTasks(workspaceId?)
useTasks->>TanStackQuery: enabled: Boolean(workspaceId)
Note over TanStackQuery: workspaceId absent OR error → data=undefined forever
TanStackQuery-->>Sidebar: data=undefined → tasksLoading=true ∞
Note over Sidebar,API: After fix
Sidebar->>useTasks: useTasks(workspaceId?)
useTasks->>TanStackQuery: queryFn = skipToken (no workspaceId)
TanStackQuery-->>Sidebar: isLoading=false (not fetching)
Note over Sidebar: skeleton dismissed ✓
useTasks->>TanStackQuery: queryFn = fetchTasks (workspaceId present)
TanStackQuery->>API: GET /tasks?workspaceId=...
API-->>TanStackQuery: TaskMetadata[]
TanStackQuery-->>Sidebar: isLoading=false, data=TaskMetadata[]
Note over Sidebar: tasks rendered ✓

Loading

_{Reviews (2): Last reviewed commit: "fix(tasks): show home UI for empty new t..." | Re-trigger Greptile}

[waleedlatif1]

@greptile

[waleedlatif1]

@cursor review

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit ef80370. Configure here.}