feat(tables): add export, import column creation, infinite row pagination by waleedlatif1 · Pull Request #4373 · simstudioai/sim

waleedlatif1 · 2026-05-01T02:02:35Z

Summary

Export: new /api/table/[tableId]/export route streams full table contents as CSV or JSON; wired into the table header as an Export action.
Import enhancements: renamed /import-csv → /import. The dialog now lets users auto-create new columns from unmapped CSV headers (passed via a createColumns form field).
Infinite row pagination + new-row fix: original bug — a 1289-row table only loaded 1000 rows and clicking "New row" past 1000 reverted the optimistic insert. Switched the table view to useInfiniteQuery (1000 rows/page), reconciled created rows into the paginated cache (position bumping + totalCount increment), added scroll-driven prefetch when within 600px of the bottom, and pre-drain pending pages before append so the new row's position stays consistent with the cache.

Test plan

Open a >1000 row table, scroll all the way down — every row should be reachable; loaded count matches header count.
Click New row at the bottom of a >1000 row table — optimistic row sticks, persists across invalidate, lands at correct position.
Filter / sort change resets pagination cleanly and the count display matches the filtered total.
Tables under 1000 rows behave unchanged (no extra fetches, no flicker).
Cell edits still optimistically update across the visible window with rollback on error.
Export CSV downloads complete table contents.
Import CSV with unmapped headers offers to create those columns; importing creates them and inserts rows.
Rapid double-click on New row does not fire two creates (drain-loop guard).

…tion - Add `/api/table/[tableId]/export` route streaming CSV/JSON downloads - Rename `/import-csv` route to `/import` and extend to auto-create new columns from unmapped CSV headers via `createColumns` form field - Switch table view to `useInfiniteQuery` so tables larger than 1000 rows fully load; reconcile created rows into the paginated cache so "New row" past 1000 no longer reverts on invalidate - Wire scroll-driven prefetch (600px from bottom) and pre-drain pages before append to keep new-row position consistent - Polish import-csv dialog flow and add Export action to header Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

vercel · 2026-05-01T02:02:39Z

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		May 1, 2026 2:49am

cursor · 2026-05-01T02:02:43Z

PR Summary

Medium Risk
Touches table import/export and row pagination/cache reconciliation, including new transactional schema mutations and infinite-query cache updates that could affect data integrity and table UX if edge cases are missed.

Overview
Adds a new streaming table export endpoint GET /api/table/[tableId]/export that downloads full table contents as CSV (default) or JSON, and wires an Export CSV action into embedded table views, the table header menu, and the tables list context menu via downloadTableExport.

Renames the existing-table CSV import route to POST /api/table/[tableId]/import and extends it with optional createColumns, allowing the server to auto-create new columns (name sanitization + type inference + collision dedupe) and perform the schema update + row writes atomically in a single DB transaction using new *WithTx service APIs.

Fixes >1000-row table behavior by switching row fetching to useInfiniteQuery pagination, adding scroll-based prefetch, draining remaining pages before appending a new row, and updating React Query cache reconciliation helpers so optimistic row creates/updates work correctly across paginated pages.

^{Reviewed by Cursor Bugbot for commit 63dc3ab. Configure here.}

greptile-apps · 2026-05-01T02:07:37Z

Greptile Summary

Review completed and submitted via mcp__greptile-review__submit_review.

Confidence Score: 5/5

Safe to merge — no blocking defects; all remaining findings are P2 style/edge-case concerns.

All P0/P1 issues are absent. Three P2 findings: transient optimistic-UI edge case in reconcileCreatedRow, known offset-pagination snapshot gap in export route, and browser memory concern for large blob downloads.

apps/sim/hooks/queries/tables.ts — reconcileCreatedRow page-selection heuristic and downloadTableExport blob buffering.

_{Reviews (4): Last reviewed commit: "fix(table): run batch unique check insid..." | Re-trigger Greptile}

Switch the table query hooks and the import/export routes to the codebase's contract-based request pattern so the API validation audit and boundary policy ratchet pass. - `hooks/queries/tables.ts` now calls every endpoint via `requestJson(contract, ...)`; the only remaining raw `fetch` calls are the streaming export download and the multipart CSV upload, both annotated `boundary-raw-fetch:`. - The import and export routes parse `params`, the `format` query, and the multipart form fields with shared schemas from `@/lib/api/contracts/tables`. Two new contract schemas (`csvImportCreateColumnsSchema`, `tableExportFormatSchema`) cover the fields specific to these routes. - Bumps the audit baseline by one route to account for the new export endpoint.

- Move the `isAppendingRowRef` reset into the create-row mutation's `onSettled` callback. The previous `try/finally` cleared the guard immediately after `mutate()` returned, before the request completed, so a rapid second click on "New row" could fire a duplicate create. - Drop the unused `addTableColumns` wrapper from `lib/table/service`. The CSV import flow only ever uses the transaction-bound `addTableColumnsWithTx`; the standalone wrapper was dead code.

waleedlatif1 · 2026-05-01T02:24:56Z

@greptile

waleedlatif1 · 2026-05-01T02:25:00Z

@cursor review

`useInfiniteQuery.fetchNextPage()` resolves (rather than rejects) when a page request fails — the resolved value carries `status: 'error'` while `hasNextPage` still reflects the last successful page. The drain loop in `handleAppendRow` relied on a thrown error to bail, so a failed mid-drain fetch could spin indefinitely and leave the append guard stuck on. Re-throw inside `fetchNextPageWrapped` when the result is an error so the caller's `try/catch` runs as intended.

…t of client bundle The client hook `use-table-data.ts` was importing `TABLE_LIMITS` as a value from the `@/lib/table` barrel, which transitively pulls in `service.ts` and the `postgres` driver. Turbopack then tried to bundle `fs`, `net`, `tls`, and `perf_hooks` into the client component graph and the production build failed. Import `TABLE_LIMITS` directly from `@/lib/table/constants` (a pure constants module) and keep the type imports against the barrel.

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 6b79524. Configure here.}

waleedlatif1 · 2026-05-01T02:41:41Z

@greptile

waleedlatif1 · 2026-05-01T02:41:45Z

@cursor review

`checkBatchUniqueConstraintsDb` queried the global `db` connection, so inside a single import transaction (one tx wrapping all batches) the constraint lookup couldn't see uncommitted rows from prior batches — duplicates that crossed `CSV_MAX_BATCH_SIZE` boundaries slipped through. Accept an optional executor and pass `trx` from `batchInsertRowsWithTx` so the lookup observes the in-flight transaction state.

waleedlatif1 · 2026-05-01T02:53:38Z

@greptile

waleedlatif1 · 2026-05-01T02:53:43Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 63dc3ab. Configure here.}

PR #4373 added apps/sim/app/api/table/[tableId]/export/route.ts but didn't update the audit baseline, so unrelated PRs fail check:api-validation:strict. Bump baseline to match current route count.

… builds (#4378) * improvement(workflow): narrow zustand selectors and optimize log tree builds - Add useIsCurrentWorkflowExecuting selector; swap broad useCurrentWorkflowExecution in action-bar/chat - Use useShallow for execution-state subset in useWorkflowExecution - Drop useCallback-wrapped object selectors in diff-controls and use-block-state (use primitive selectors) - Stabilize EMPTY_SUBBLOCK_VALUES constant for empty-workflow selector results in api-info-modal, mcp, tag-dropdown - O(n) Map lookups in buildEntryTree (was O(n^2) filter scans) - Skip expanded-paths reset when structured-output data is content-stable - Extract ReactFlow constants out of workflow.tsx into workflow-constants.ts * fix(workflow): seed structured-output JSON ref and centralize EMPTY_SUBBLOCK_VALUES - Use null sentinel for prevDataJsonRef and lazily stringify prevDataRef on first compare so the optimization holds on the first stream refresh after mount - Export EMPTY_SUBBLOCK_VALUES from the subblock store; remove three duplicated module constants * chore(ci): bump api-validation route baseline to 717 PR #4373 added apps/sim/app/api/table/[tableId]/export/route.ts but didn't update the audit baseline, so unrelated PRs fail check:api-validation:strict. Bump baseline to match current route count.

cursorBot reviewed May 1, 2026
View reviewed changes

Comment threadapps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table/table.tsx
Comment threadapps/sim/lib/table/service.ts Outdated

waleedlatif1 added 2 commits April 30, 2026 19:21

vercelBottemporarily deployed to Preview May 1, 2026 02:23 Inactive

greptile-appsBot reviewed May 1, 2026
View reviewed changes

Comment threadapps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table/table.tsx

vercelBottemporarily deployed to Preview May 1, 2026 02:33 Inactive

vercelBottemporarily deployed to Preview May 1, 2026 02:35 Inactive

cursorBot reviewed May 1, 2026
View reviewed changes

Comment threadapps/sim/app/api/table/[tableId]/import/route.ts

vercelBottemporarily deployed to Preview May 1, 2026 02:49 Inactive

cursorBot reviewed May 1, 2026
View reviewed changes

waleedlatif1 merged commit a9c12a2 into stagingMay 1, 2026
14 checks passed

waleedlatif1 deleted the waleedlatif1/table-export-import branch May 1, 2026 17:00

waleedlatif1 mentioned this pull request May 1, 2026
v0.6.62: firecrawl parse, new gmail tools, trace improvements, tool fixes, db query optimizations, contract boundaries code hygiene, CORS, toast improvements, tables infinite query, executor robustness, reranker support #4390
Merged

Uh oh!

Conversation

waleedlatif1 commented May 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test plan

Uh oh!

vercelBot commented May 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursorBot commented May 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

greptile-appsBot commented May 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 5/5

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented May 1, 2026

Uh oh!

waleedlatif1 commented May 1, 2026

Uh oh!

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented May 1, 2026

Uh oh!

waleedlatif1 commented May 1, 2026

Uh oh!

Uh oh!

waleedlatif1 commented May 1, 2026

Uh oh!

waleedlatif1 commented May 1, 2026

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

waleedlatif1 commented May 1, 2026•
edited
Loading

vercelBot commented May 1, 2026•
edited
Loading

cursorBot commented May 1, 2026•
edited
Loading

greptile-appsBot commented May 1, 2026•
edited
Loading