improvement(mothership): reuse logs detail panel in resource view

[waleedlatif1]

Summary

• Extract LogDetailsContent (tabs + sections + snapshot modal) from the revamped logs sidebar so it can be reused
• Replace the mothership tasks-chat EmbeddedLog (~270 lines duplicating the old panel) with a thin wrapper around LogDetailsContent — net −239 lines
• Mothership log resources now match the logs sidebar exactly: Overview/Trace tabs, run-ID copy, cost breakdown, snapshot modal
• Swap a redundant useState for useRef in LogDetails since the active-tab value is only read inside the keyboard effect

Type of Change

• Improvement (refactor + visual parity)

Testing

Tested manually — opened a log resource in mothership and confirmed the panel renders identically to the logs sidebar (tabs, output, trace, cost, snapshot). tsc --noEmit and biome both clean on the touched files.

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		May 1, 2026 11:43pm

[cursor]

PR Summary

Medium Risk
Moderate UI refactor in log details rendering; risk is mainly regressions in tab state/keyboard navigation and parity between embedded and sidebar views.

Overview
Mothership log resources now render via the shared logs details body (LogDetailsContent) instead of maintaining a separate ~270-line duplicated EmbeddedLog implementation, ensuring UI parity (Overview/Trace tabs, snapshot modal, run-id copy, cost/output sections).

The logs sidebar (LogDetails) is split into reusable content vs. sidebar chrome, exports LogDetailsContent/LogDetailsTab, and updates keyboard navigation to track the active tab via a useRef so TraceView can own arrow-key handling.

^{Reviewed by Cursor Bugbot for commit c5b4199. Configure here.}

[greptile-apps]

Greptile Summary

This PR extracts LogDetailsContent (the tabbed body: overview details, trace spans, snapshot modal) from LogDetails into its own exported component, then replaces the ~270-line EmbeddedLog implementation in the mothership resource panel with a thin wrapper around it. The refactor eliminates code duplication and ensures the mothership view stays in sync with the logs sidebar automatically going forward.

Confidence Score: 5/5

Safe to merge — clean refactor with no logic changes on existing paths and correct null-guarding throughout.

No P0 or P1 findings. The extraction is structurally sound: LogDetailsContent's flex/min-h-0 chain is compatible with both host containers, the stale-activeTabRef bug is correctly fixed, and the EmbeddedLog null guards prevent passing undefined to the non-nullable prop. All removed code was dead duplication.

No files require special attention.

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/logs/components/log-details/log-details.tsx	Extracts LogDetailsContent from LogDetails; fixes the stale-activeTabRef bug by removing the resolvedTab !== activeTab guard; swaps resolvedTab in the keyboard useEffect dep array for a ref read — all changes are correct.
apps/sim/app/workspace/[workspaceId]/home/components/mothership-view/components/resource-content/resource-content.tsx	EmbeddedLog shrinks from ~270 lines to 9 lines by delegating to LogDetailsContent; null-guards before passing log are correct; layout wrapper (flex flex-col overflow-hidden) is compatible with LogDetailsContent's flex-1 min-h-0 chain.
apps/sim/app/workspace/[workspaceId]/logs/components/index.ts	Adds LogDetailsContent and the LogDetailsTab type to the public barrel export — straightforward, no issues.
apps/sim/app/workspace/[workspaceId]/logs/components/log-details/index.ts	Inner barrel updated to mirror the outer barrel; trivial change.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[LogDetails sidebar] -->|renders chrome + keyboard nav| B[LogDetailsContent]
C[EmbeddedLog mothership] -->|thin wrapper| B
B --> D[SModalTabs - Overview / Trace]
B --> E[ExecutionSnapshot modal]
D --> F[WorkflowOutputSection]
D --> G[TraceView]
D --> H[FileCards]
D --> I[CostBreakdown]
A -->|activeTabRef via onActiveTabChange| J[Keyboard nav guard]

Loading

_{Reviews (2): Last reviewed commit: "fix(logs): notify embedder on every reso..." | Re-trigger Greptile}

[waleedlatif1]

@greptile

[waleedlatif1]

@cursor review

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit c5b4199. Configure here.}