Skip to content

fix(csp): allow https images in markdown preview and html sandbox#4394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 4 commits into from
May 2, 2026
Merged

fix(csp): allow https images in markdown preview and html sandbox #4394

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2f28155
fix(csp): allow https images in markdown preview and html sandbox
waleedlatif1 May 2, 2026
a3905af
fix(csp): remove inoperative self token from sandboxed html preview i…
waleedlatif1 May 2, 2026
7a18f1f
chore(csp): remove redundant img-src entries superseded by https scheme
waleedlatif1 May 2, 2026
4c08519
fix(csp): revert html preview img-src to data: blob: to preserve conn…
waleedlatif1 May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 3 additions & 33 deletions apps/sim/lib/core/security/csp.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -61,23 +61,7 @@ const STATIC_SCRIPT_SRC = [
: []),
] as const

const STATIC_IMG_SRC = [
"'self'",
'data:',
'blob:',
'https://*.googleusercontent.com',
'https://*.google.com',
'https://*.atlassian.com',
'https://cdn.discordapp.com',
'https://*.githubusercontent.com',
'https://*.s3.amazonaws.com',
'https://s3.amazonaws.com',
'https://*.amazonaws.com',
'https://*.blob.core.windows.net',
'https://github.com/*',
'https://cursor.com',
...(isHosted ? ['https://www.googletagmanager.com', 'https://www.google-analytics.com'] : []),
] as const
const STATIC_IMG_SRC = ["'self'", 'data:', 'blob:', 'https:'] as const
Comment thread
waleedlatif1 marked this conversation as resolved.

const STATIC_CONNECT_SRC = [
"'self'",
Expand DownExpand Up@@ -147,20 +131,7 @@ export const buildTimeCSPDirectives: CSPDirectives = {
'script-src': [...STATIC_SCRIPT_SRC],
'style-src': ["'self'", "'unsafe-inline'", 'https://fonts.googleapis.com'],

'img-src': [
...STATIC_IMG_SRC,
...(env.S3_BUCKET_NAME && env.AWS_REGION
? [`https://${env.S3_BUCKET_NAME}.s3.${env.AWS_REGION}.amazonaws.com`]
: []),
...(env.S3_KB_BUCKET_NAME && env.AWS_REGION
? [`https://${env.S3_KB_BUCKET_NAME}.s3.${env.AWS_REGION}.amazonaws.com`]
: []),
...(env.S3_CHAT_BUCKET_NAME && env.AWS_REGION
? [`https://${env.S3_CHAT_BUCKET_NAME}.s3.${env.AWS_REGION}.amazonaws.com`]
: []),
...getHostnameFromUrl(env.NEXT_PUBLIC_BRAND_LOGO_URL),
...getHostnameFromUrl(env.NEXT_PUBLIC_BRAND_FAVICON_URL),
],
'img-src': [...STATIC_IMG_SRC],

'media-src': ["'self'", 'blob:'],
'worker-src': ["'self'", 'blob:'],
Expand DownExpand Up@@ -216,14 +187,13 @@ export function generateRuntimeCSP(): string {
const ollamaUrl = getEnv('OLLAMA_URL') || (isDev ? DEFAULT_OLLAMA_URL : '')

const brandLogoDomains = getHostnameFromUrl(getEnv('NEXT_PUBLIC_BRAND_LOGO_URL'))
const brandFaviconDomains = getHostnameFromUrl(getEnv('NEXT_PUBLIC_BRAND_FAVICON_URL'))
const privacyDomains = getHostnameFromUrl(getEnv('NEXT_PUBLIC_PRIVACY_URL'))
const termsDomains = getHostnameFromUrl(getEnv('NEXT_PUBLIC_TERMS_URL'))

const runtimeDirectives: CSPDirectives = {
...buildTimeCSPDirectives,

'img-src': [...STATIC_IMG_SRC, ...brandLogoDomains, ...brandFaviconDomains],
'img-src': [...STATIC_IMG_SRC],

'connect-src': [
...STATIC_CONNECT_SRC,
Expand Down
Loading