refactor(tables): row selection as discriminated union

[waleedlatif1]

Summary

• Collapse checkedRows: Set<string> + allRowsSelected: boolean into a single RowSelection = { kind: 'none' | 'some' | 'all' }
• Impossible states (all + non-empty Set, both true) become unrepresentable
• All read sites use predicates (rowSelectionIncludes, rowSelectionIsEmpty) instead of ad-hoc checks
• All write sites use a single setRowSelection call instead of paired updates

Type of Change

• Refactor

Testing

Tested manually — gutter check, shift-range check, Cmd+A, master toggle, copy/cut/delete on selection, context menu delete all behave identically.

Checklist

• Code follows project style guidelines
• Self-reviewed my changes
• Tests added/updated and passing
• No new warnings introduced
• I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
docs	Skipped		May 6, 2026 4:27am

[cursor]

PR Summary

Medium Risk
Touches table row-selection state used by delete/cut/copy and context-menu actions, so a bug could affect which rows are modified or removed. Scope is limited to the table UI and is largely a mechanical refactor.

Overview
Row selection state is refactored from a plain Set (plus implicit/derived “all selected” logic) into a single RowSelection discriminated union (none | some | all) with helper predicates for inclusion/emptiness/materialization.

All table interactions that depend on row selection (select-all toggle, shift checkbox ranges, context-menu delete, keyboard delete/backspace, copy/cut, and row checkbox rendering) are updated to read/write RowSelection consistently, including correctly handling the all case without enumerating ids. A small rename clarifies memo logic (rowSelectionChanged → cellRangeRowChanged) and row highlight behavior is simplified to depend on checkbox selection only.

^{Reviewed by Cursor Bugbot for commit e64787e. Configure here.}

[greptile-apps]

Greptile Summary

This PR replaces two coupled state variables (checkedRows: Set<string> + allRowsSelected: boolean) in the Table component with a single discriminated union RowSelection = { kind: 'none' } | { kind: 'some'; ids: Set<string> } | { kind: 'all' }, eliminating previously representable impossible states and centralizing all read/write access through a small set of pure helper functions.

• Five module-level pure functions (rowSelectionIncludes, rowSelectionIsEmpty, rowSelectionMaterialize, rowSelectionCoversAll, and a renamed cellRangeRowChanged) replace ad-hoc inline checks at every call site.
• All write sites are collapsed to a single setRowSelection call; handleRowToggle materialises the current selection into a temporary Set, mutates it, and normalises back to ROW_SELECTION_NONE when empty, preventing the { kind: 'some', ids: new Set() } dead state.
• The isAllRowsSelected memo and selectedRowCount memo are updated to use the new helpers; the removed isRowSelectedByRange path in DataRow reflects the intentional decoupling of gutter-checkbox selection from cell-range highlight established in fix(tables): decouple master checkbox from cell-range #4464.

Confidence Score: 5/5

Safe to merge — the change is a pure internal refactor of two coupled state variables into a discriminated union with no external API changes, all call sites updated consistently, and the only behavioural difference (row-range highlight decoupling) is intentional and documented.

The helper functions are correct pure functions with no side effects, handleRowToggle correctly prevents the { kind: 'some', ids: new Set() } dead state, rowSelectionCoversAll handles all three kinds correctly, and the materialization path in the checkbox handler is safe. The previously noted issues around selectedRowCount and the blank-line style nit are already addressed in the companion commit. No logic regressions identified.

No files require special attention.

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table/table.tsx	Discriminated union refactor replacing two coupled state variables with a single RowSelection type; all read/write sites updated consistently, helpers are correct, no new impossible states introduced, and previous thread issues (selectedRowCount guard, blank line) are already resolved in the companion commit 0f986cf.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
NONE["RowSelection\nkind: 'none'"]
SOME["RowSelection\nkind: 'some'\nids: Set<string>"]
ALL["RowSelection\nkind: 'all'"]
NONE -->|"handleRowToggle (check row)"| SOME
SOME -->|"handleRowToggle (uncheck last row)"| NONE
SOME -->|"handleRowToggle (shift-range / toggle)"| SOME
SOME -->|"rowSelectionCoversAll → true (master toggle)"| ALL
ALL -->|"handleRowToggle (uncheck any row) via rowSelectionMaterialize"| SOME
ALL -->|"handleClearSelection / cell click"| NONE
NONE -->|"handleSelectAllRows / master toggle"| ALL
SOME -->|"handleClearSelection / cell click"| NONE

Loading

_{Reviews (5): Last reviewed commit: "fix(tables): guard context-menu delete o..." | Re-trigger Greptile}

[waleedlatif1]

@greptile

[waleedlatif1]

@cursor review

[waleedlatif1]

@greptile

[waleedlatif1]

@greptile

[waleedlatif1]

@cursor review

[waleedlatif1]

@cursor review

[waleedlatif1]

@greptile

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit e64787e. Configure here.}