Uh oh!
There was an error while loading. Please reload this page.
improvement(apollo): align tools and block with Apollo API docs - #4487
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview This expands supported filters/fields for people/org/contact/account/opportunity/sequence/task operations, adjusts endpoints and payload formats (notably bulk create/update, people enrich phone reveal via Adds Apollo-specific subblock ID migrations and block-side JSON parsing/mapping to preserve backwards compatibility while introducing new inputs like uniform bulk-update ( Reviewed by Cursor Bugbot for commit ae40b0e. Configure here. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Greptile SummaryThis PR aligns all 25 Apollo tools and the Apollo block with the official Apollo API documentation, fixing endpoints, request shapes, and field names across the full tool suite. All previously-flagged issues from iterative review rounds have been resolved in follow-up commits.
Confidence Score: 5/5Safe to merge — all previously-identified issues have been resolved in follow-up commits and the current code is consistent across tools, block, and migration table. The bulk-update guard logic in both contact and account tools now covers every invalid input combination. The subblock migration table is complete with no dangerous blanket renames. Endpoint changes are internally consistent and the block params function correctly remaps all renamed subblock IDs before dispatching to tools. No files require special attention — the most sensitive areas (bulk-update guards and migration table) were reviewed thoroughly and are correct. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[account_bulk_update call] --> B{account_ids provided?}
B -- yes --> C[body.account_ids = ids]
B -- no --> D[body.account_ids empty]
C --> E{name / owner_id provided?}
D --> E
E -- yes --> F[add name/owner_id to body]
E -- no --> G[skip]
F --> H{account_attributes provided?}
G --> H
H -- array form --> I[body.account_attributes = array]
H -- object form --> J[body.account_attributes = object]
H -- absent --> K[skip]
I --> L{hasUpdateFields?}
J --> L
K --> L
L -- no --> M[throw: no update fields]
L -- yes --> N{account_ids AND account_attributes absent?}
N -- yes --> O[throw: need ids or attributes]
N -- no --> P{object-form attrs WITHOUT account_ids?}
P -- yes --> Q[throw: object attrs require account_ids]
P -- no --> R{account_ids AND array-form attrs?}
R -- yes --> S[throw: cannot combine]
R -- no --> T[dispatch to Apollo]
Reviews (17): Last reviewed commit: "fix(apollo): reject ambiguous account/co..." | Re-trigger Greptile |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
e59ab46 to
7447852Comparewaleedlatif1
commented
May 7, 2026
waleedlatif1
commented
May 7, 2026
@cursor review |
waleedlatif1
commented
May 7, 2026
bugbot run |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
waleedlatif1
commented
May 7, 2026
@cursor review |
waleedlatif1
commented
May 7, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
waleedlatif1
commented
May 8, 2026
@cursor review |
waleedlatif1
commented
May 8, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…lk limit, expose async toggle for accounts
waleedlatif1
commented
May 8, 2026
waleedlatif1
commented
May 8, 2026
@cursor review |
Uh oh!
There was an error while loading. Please reload this page.
waleedlatif1
commented
May 8, 2026
waleedlatif1
commented
May 8, 2026
@cursor review |
Uh oh!
There was an error while loading. Please reload this page.
…mpty attribute objects
waleedlatif1
commented
May 8, 2026
waleedlatif1
commented
May 8, 2026
@cursor review |
Uh oh!
There was an error while loading. Please reload this page.
waleedlatif1
commented
May 8, 2026
waleedlatif1
commented
May 8, 2026
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit ae40b0e. Configure here.
Uh oh!
There was an error while loading. Please reload this page.
Summary
Type of Change
Testing
Tested manually. Lint and typecheck pass.
Checklist