Uh oh!
There was an error while loading. Please reload this page.
fix(table): fix table boolean, add dynamic row number col size, search & replace improvements - #4515
Conversation
…tyle for search and replace
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview Improves workflow editor search/replace: introduces a shared highlight style and supports nested field highlighting for Hardens execution variable interpolation for function blocks by detecting whether a Reviewed by Cursor Bugbot for commit e716220. Configure here. |
Uh oh!
There was an error while loading. Please reload this page.
Greptile SummaryThis PR delivers a set of targeted bug fixes and improvements across the table module and the workflow search-replace system. The most substantial work is in the search-replace indexer: it now handles
Confidence Score: 5/5This PR is safe to merge. All changes are well-scoped bug fixes and refactors with good test coverage. The resolver scanner is the highest-risk new logic; it is exercised by a comprehensive suite of unit tests covering JS strings, template literals, template expressions, Python single/double/triple-quoted strings, escaped characters, and comment handling. The search-replace refactoring consolidates previously scattered files into a clean resource registry and is backed by extensive indexer and replacements tests. The table-grid changes are mechanical and easy to verify visually. No files require special attention; the indexer and resolver changes are the most complex but are well covered by tests. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[indexWorkflowSearchMatches] --> B{subBlock type?}
B -->|tool-input| C[addToolInputMatches]
B -->|display-only| D[skip]
B -->|other| E{mode?}
C --> F[parseStoredToolInputValue]
F --> G[getToolInputParamConfigs]
G --> H[buildToolInputSearchConfig per param]
H --> I[addTextMatches / addInlineReferenceMatches]
E -->|text mode| J[getTextLeaves]
J --> K{isSearchableJsonValueSubBlock?}
K -->|yes| L[getSearchableJsonStringLeaves]
K -->|no| M[getSearchableStringLeaves]
L --> N[addTextMatches]
M --> N
E -->|resource mode| O[getSearchableStringLeaves reference]
O --> P[parseInlineReferences]
O --> Q[parseStructuredResourceReferences]
P --> R[environment / workflow-reference matches]
Q --> S[structured resource matches]
subgraph Resolver
T[formatCodeContextVariableReference] --> U[getCodeStringQuoteContext]
U --> V{context?}
V -->|template| W[wrap in dollar-brace]
V -->|single/double/triple| X[break string + dumps/stringify]
V -->|null code context| Y[plain globalThis/globals ref]
end
Reviews (7): Last reviewed commit: "escaped behaviour" | Re-trigger Greptile |
Uh oh!
There was an error while loading. Please reload this page.
…_CLASS to shared constants
waleedlatif1
commented
May 8, 2026
waleedlatif1
commented
May 8, 2026
@cursor review |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 3e0ef3a. Configure here.
waleedlatif1
commented
May 8, 2026
icecrasher321
commented
May 8, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
icecrasher321
commented
May 8, 2026
icecrasher321
commented
May 8, 2026
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 427a530. Configure here.
waleedlatif1
commented
May 8, 2026
waleedlatif1
commented
May 8, 2026
@cursor review |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit e716220. Configure here.
icecrasher321
commented
May 8, 2026
Uh oh!
There was an error while loading. Please reload this page.
Summary
Type of Change
Testing
Manually
Checklist