Uh oh!
There was an error while loading. Please reload this page.
improvement(sandbox): expand document generation — style extraction, sandbox hardening, OOM errors, task guards - #4526
Conversation
…sandbox hardening, OOM errors, PPTX/DOCX/PDF task guards
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryMedium Risk Overview Improves OOXML extraction robustness by making DOCX themes optional (LibreOffice compatibility), resolving style inheritance/theme fonts, and enriching PPTX metadata; updates the sandbox worker to surface a friendlier OOM error before cancellation detection. Enhances document generation tasks: DOCX chunked mode can now pass document-wide options via Reviewed by Cursor Bugbot for commit d251915. Configure here. |
Greptile SummaryThis PR expands document style extraction to cover PDF files (via
Confidence Score: 5/5Safe to merge — all logic paths are well-guarded and the OOM ordering fix corrects a genuine misclassification without introducing new failure modes. The OOM reordering is the most load-bearing change and it is clearly correct: OOM auto-disposes the isolate, so the old code's isDisposed check would fire first and mask the real error. Moving OOM detection above the dispose check eliminates that ambiguity. The style-extraction additions are well-insulated behind try/catch at every layer (outer, per-page, per-font-entry), so a malformed or unusual document degrades gracefully to null. The contract schema changes are additive and backward-compatible. No existing call sites are broken. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "chore(lint): suppress noTemplateCurlyInS..." | Re-trigger Greptile |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
…ance sentinel in docx style extractor
waleedlatif1
commented
May 9, 2026
@cursor review |
waleedlatif1
commented
May 9, 2026
…ings intentionally assert template literal preservation
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit d251915. Configure here.
Summary
__docxDocOptionsto docx sandbox bootstrap/finalize so chunked mode can set document-wide styles and numberingType of Change
Testing
Tested manually
Checklist