fix(tables): fix bulk ops truncation for tables larger than one page by waleedlatif1 · Pull Request #4532 · simstudioai/sim

waleedlatif1 · 2026-05-09T05:49:49Z

Summary

Bulk ops (column clear, copy, cut, delete, run) were silently truncated to 1000 rows on tables with more than one page of data
Added background page drain via `useEffect` + `fetchNextPage` so all pages load automatically after mount
Added `ensureAllRowsLoaded` helper that gates bulk ops — awaits any remaining pages before proceeding
Fixed undo/redo regression: batch update mutations now chunk by `MAX_BULK_OPERATION_SIZE` to stay within server limits on large tables
Added new `tableRowsInfiniteOptions` factory so the hook and imperative drain calls share the same cache key
Added tests for chunking logic in `use-table-undo` and drain logic in `use-table`

Type of Change

Bug fix

Testing

Tested manually — verified all rows clear/copy/cut/delete correctly on tables >1000 rows. All unit tests passing.

Checklist

Code follows project style guidelines
Self-reviewed my changes
Tests added/updated and passing
No new warnings introduced
I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

vercel · 2026-05-09T05:49:55Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
docs	Ready	Preview, Comment	May 9, 2026 8:07pm

cursor · 2026-05-09T05:49:58Z

PR Summary

Medium Risk
Touches table-grid bulk operations (copy/cut/clear/delete/run) and undo/redo batching, adding async page-draining and chunked mutations; regressions could affect large-table edits and clipboard behavior. No auth/security changes.

Overview
Fixes bulk table operations silently stopping at the first 1000 loaded rows by adding useTable.ensureAllRowsLoaded() (drains React Query infinite pages via a shared tableRowsInfiniteOptions cache key) and gating bulk clear/copy/cut/delete flows on it.

Updates bulk mutations to respect server batch limits by chunking batchUpdate calls (including undo/redo via an async runWithoutRecording) and adds targeted unit tests for the drain/chunk logic.

Smaller UX/validation tweaks: string cells auto-render valid URLs as external links with favicons (adds tldts), number cleaning now yields null instead of 0 on invalid input, CSV-imported table names are truncated to TABLE_LIMITS.MAX_TABLE_NAME_LENGTH (which is increased to 128), and CSV import errors now toast the server message.

^{Reviewed by Cursor Bugbot for commit 290b4bf. Configure here.}

greptile-apps · 2026-05-09T05:57:18Z

Greptile Summary

This PR fixes bulk-operation truncation on large tables (>1 page) by adding ensureAllRowsLoaded — a React Query cache drain that fetches all remaining pages before clear, copy, cut, and delete ops execute. It also introduces chunked batch mutations (chunkBatchUpdates) to stay within server size limits, upgrades runWithoutRecording to async so the undo guard spans the full operation, and surfaces previously-silent CSV import errors via onError toasts.

ensureAllRowsLoaded: shares tableRowsInfiniteOptions query key with the hook so cache reads are coherent; called via ref in all bulk keyboard handlers before building mutation payloads.
chunkBatchUpdates: splits updates into MAX_BULK_OPERATION_SIZE chunks dispatched 3-at-a-time; used in table-grid.tsx op handlers and undo/redo in use-table-undo.ts.
selectedRunScope.allRows: header-checkbox selection now propagates allRows: true to table.tsx, which passes rowIds: undefined to the server — but the sameRunScope snapshot equality check does not compare allRows, so this fix doesn't take effect when transitioning from a fully-manually-selected page to "select all".

Confidence Score: 3/5

Not safe to merge as-is: the run-scope fix is incomplete and the header-checkbox 'run all rows' path remains truncated to the loaded page.

The sameRunScope check in table-grid.tsx (lines 2859-2867) compares groupIds and rowIds element-by-element but skips allRows. A user who manually selects all loaded rows then clicks the header checkbox produces identical rowIds arrays with different allRows values; the snapshot is not re-emitted; table.tsx retains allRows: false; and runScope is called with explicit row IDs rather than undefined, capping the run to the first page — the truncation the PR set out to fix.

table-grid.tsx — sameRunScope equality check needs allRows comparison; cell-render.tsx — Google favicon service makes external requests for every URL-valued cell

Important Files Changed

Filename	Overview
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx	Bulk ops (clear, copy, cut) now correctly drain all pages via `ensureAllRowsLoaded`; `selectedRunScope` gains `allRows: true` for header-checkbox selections; but `sameRunScope` equality check does not compare `allRows`, so a transition from manually-selecting all loaded rows to header checkbox won't re-emit the snapshot and `table.tsx` retains stale `allRows: false`, truncating the run
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/hooks/use-table.ts	Adds `ensureAllRowsLoaded`: reads from React Query cache synchronously after each `fetchNextPage` to drain all pages; correctly shares the `tableRowsInfiniteOptions` query key with `useInfiniteTableRows` to ensure cache coherence
apps/sim/hooks/queries/tables.ts	Extracts `tableRowsInfiniteOptions` factory to share query key between hook and imperative drain; adds `toast.error` to CSV upload `onError` callbacks to surface previously-silent validation failures
apps/sim/hooks/use-table-undo.ts	Batch update mutations now chunk by `MAX_BULK_OPERATION_SIZE` to stay within server limits; `executeAction` is async so `runWithoutRecording` guards the full operation; the `delete-column` undo path's cell-restore batch runs in a fire-and-forget IIFE inside `onSuccess`, so errors are only logged with no user toast
apps/sim/stores/table/store.ts	`runWithoutRecording` upgraded from sync to async: `undoRedoInProgress` flag now stays `true` until the returned Promise settles, correctly guarding chunked batch mutations
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/cells/cell-render.tsx	Adds URL auto-detection for string columns: validates with `new URL()` or `BARE_DOMAIN_RE`+`tldts.isIcann`, renders clickable links with Google favicon service; favicon requests leak cell domains to an external service
apps/sim/app/workspace/[workspaceId]/tables/[tableId]/table.tsx	`onPlay`/`onRefresh` now pass `rowIds: undefined` when `allRows: true`, correctly requesting a server-side full-table run; stop correctly calls `onStopAll()` for all-row selections
apps/sim/lib/table/constants.ts	`MAX_TABLE_NAME_LENGTH` raised from 50 to 128; adds `MAX_BULK_OPERATION_SIZE` constant that gates chunking across multiple call sites

Sequence Diagram

sequenceDiagram
participant User
participant TableGrid
participant ensureAllRowsLoaded
participant ReactQueryCache
participant Server
User->>TableGrid: Bulk op (Delete/Clear/Copy/Cut) on row selection
TableGrid->>ensureAllRowsLoaded: await ensureAllRowsLoadedRef.current()
loop "until lastPage.rows.length < MAX_QUERY_LIMIT"
ensureAllRowsLoaded->>ReactQueryCache: getQueryData(queryKey)
ensureAllRowsLoaded->>Server: fetchNextPage()
Server-->>ReactQueryCache: page N rows
end
ensureAllRowsLoaded-->>TableGrid: all rows[]
TableGrid->>TableGrid: pushUndo(undoCells)
TableGrid->>Server: chunkBatchUpdates (3 concurrent chunks)
Server-->>TableGrid: success / error

Comments Outside Diff (1)

apps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx, line 2859-2867 (link)
sameRunScope omits allRows — stale flag silently truncates run
sameRunScope compares groupIds and rowIds element-by-element but never checks the new allRows field. When a user manually checks all loaded rows (rowSelection.kind === 'some', allRows: false) and then clicks the header checkbox to "select all" (rowSelection.kind === 'all', allRows: true), both states produce a selectedRunScope with the same rowIds array. sameRunScope returns true, the snapshot is not re-emitted, and table.tsx retains the stale allRows: false. onPlay/onRefresh then call runScope with explicit row IDs instead of rowIds: undefined, silently truncating the run to the loaded page — the exact bug this PR claims to fix.
Add && prev.selectedRunScope.allRows === selectedRunScope.allRows to the equality check.

_{Reviews (8): Last reviewed commit: "feat(tables): clickable URL cells with f..." | Re-trigger Greptile}

waleedlatif1 · 2026-05-09T06:02:59Z

@greptile

waleedlatif1 · 2026-05-09T06:03:02Z

@cursor review

waleedlatif1 · 2026-05-09T06:51:40Z

@cursor review

waleedlatif1 · 2026-05-09T06:51:41Z

@greptile

waleedlatif1 · 2026-05-09T07:11:09Z

@cursor review

waleedlatif1 · 2026-05-09T07:11:14Z

@greptile

waleedlatif1 · 2026-05-09T18:18:44Z

@greptile

waleedlatif1 · 2026-05-09T18:18:47Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit a89ee35. Configure here.}

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 2ba4836. Configure here.}

Bulk operations (column-header delete, select-all copy/cut/delete/run) were silently truncated to the first 1000 rows because handlers only iterated the loaded pages from useInfiniteQuery. Fix: - Extract tableRowsInfiniteOptions factory (infiniteQueryOptions) so the hook and imperative drain share the same typed cache key - Add background drain via useEffect watching hasNextPage/isFetchingNextPage — chains fetchNextPage until getNextPageParam returns undefined - Add ensureAllRowsLoaded to use-table: reads cache via getQueryData + calls fetchNextPage in a while loop until the last page is partial - Await ensureAllRowsLoaded at every kind:'all' bulk-op entry point in table-grid (column delete, copy, cut, action-bar delete/run) - Add chunkBatchUpdates to send updates in MAX_BULK_OPERATION_SIZE=1000 chunks so server validation never rejects oversized batches - Fix undo-redo: make executeAction async and chunk clear-cells, update-cells, and delete-column cell-restore with mutateAsync loops Tests: 41 passing across use-table, tables queries, and use-table-undo

…te and cut

…g cache merge

… in polling loop

…ipboard NotAllowedError

… cell deletion

…unk failures

…error toast; column-cut drain

…entity - Fix polling tick: move Promise.all inside else-branch so dirty[] stays in scope; keep hasDirty=true during active mutations so the short interval fires while chunked batch-updates are in flight - Add isColumnSelectionRef branch to handleCopy (mirrors handleCut fix): column-header Cmd+C now drains all pages before building clipboard content - Replace String(updatedAt) comparison in mergePagePreservingIdentity with Date.getTime() equality — handles ISO vs +00:00 timezone variants - Remove redundant batchUpdates.length > 0 guards at chunkBatchUpdates callsites (empty-array case is handled inside the function) - Export _mergePagePreservingIdentity for unit testing - Add 6 unit tests covering mergePagePreservingIdentity edge cases

…s, fix ref sync

…ch updates - Drop the per-page polling loop — SSE stream already patches execution cell state in real time and invalidates on buffer prune; polling was redundant and burned CPU/network on every open table - Remove eager mount drain (fetchNextPage loop in use-table.ts); scroll handler and ensureAllRowsLoaded handle progressive/on-demand loading - Parallelize chunkBatchUpdates with a 3-worker pool instead of serial chunks, reducing bulk-op round-trips by ~3x - Delete mergePagePreservingIdentity and its tests (no longer called)

- Fix chunkBatchUpdates JSDoc to reflect parallel dispatch (was "sequentially") - Inline CHUNK_CONCURRENCY=3, single-use constant needs no abstraction - Drop stale "Polls while any cell is in flight" from useTableRows JSDoc - Remove two generic "Validation errors surfaced by caller" comments - Remove ASCII separator line from workflow group mutations section - Remove dead `if (!variables) return` guard in useImportCsvIntoTable onSettled (TanStack v5 always provides variables to onSettled)

…ded pages When rowSelection.kind === 'all', selectedRunScope now flags allRows: true. The action-bar run handlers pass rowIds: undefined to the server when allRows is set, matching the server contract (missing rowIds = run all eligible rows). Stop likewise routes through scope: 'all' instead of per-row cancels. Previously, selecting all rows and clicking Run would silently only run the rows loaded in the current infinite-query cache (potentially one page of 1000 on a 5000-row table).

…ionally removed)

…oupExecution

…ss covers full undo execution

waleedlatif1 · 2026-05-09T20:04:58Z

@greptile

waleedlatif1 · 2026-05-09T20:05:01Z

@cursor review

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 290b4bf. Configure here.}

cursorBot reviewed May 9, 2026
View reviewed changes

Comment threadapps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx
Comment threadapps/sim/hooks/use-table-undo.ts Outdated

greptile-appsBot reviewed May 9, 2026
View reviewed changes

Comment threadapps/sim/hooks/queries/tables.ts
Comment threadapps/sim/app/workspace/[workspaceId]/tables/[tableId]/hooks/use-table.ts
Comment threadapps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx

vercelBottemporarily deployed to Preview May 9, 2026 05:58 Inactive

vercelBottemporarily deployed to Preview May 9, 2026 06:05 Inactive

cursorBot reviewed May 9, 2026
View reviewed changes

Comment threadapps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx Outdated
Comment threadapps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx Outdated

vercelBottemporarily deployed to Preview May 9, 2026 06:26 Inactive

vercelBottemporarily deployed to Preview May 9, 2026 06:44 Inactive

vercelBottemporarily deployed to Preview May 9, 2026 06:51 Inactive

greptile-appsBot reviewed May 9, 2026
View reviewed changes

Comment threadapps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx

cursorBot reviewed May 9, 2026
View reviewed changes

Comment threadapps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx
Comment threadapps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx

vercelBottemporarily deployed to Preview May 9, 2026 07:03 Inactive

vercelBottemporarily deployed to Preview May 9, 2026 07:08 Inactive

greptile-appsBot reviewed May 9, 2026
View reviewed changes

Comment thread.../app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/cells/inline-editors.tsx

cursorBot reviewed May 9, 2026
View reviewed changes

Comment threadapps/sim/hooks/queries/tables.ts Outdated
Comment threadapps/sim/hooks/queries/tables.ts
Comment threadapps/sim/app/workspace/[workspaceId]/tables/[tableId]/components/table-grid/table-grid.tsx Outdated

vercelBottemporarily deployed to Preview May 9, 2026 16:52 Inactive

vercelBottemporarily deployed to Preview May 9, 2026 17:12 Inactive

vercelBottemporarily deployed to Preview May 9, 2026 18:18 Inactive

cursorBot reviewed May 9, 2026
View reviewed changes

vercelBottemporarily deployed to Preview May 9, 2026 18:36 Inactive

cursorBot reviewed May 9, 2026
View reviewed changes

vercelBottemporarily deployed to Preview May 9, 2026 19:42 Inactive

waleedlatif1 added 20 commits May 9, 2026 13:03

chore(tables): remove extraneous comments
9099a98

fix(tables): add missing useEffect import; chunk range-selection dele…
61752e9
…te and cut

fix(tables): add hasRunningGroupExecution and import it
2cb026d

fix(tables): define mergePagePreservingIdentity helper used in pollin…
a4e7db2
…g cache merge

fix(tables): define ROWS_POLL_INTERVAL_WHILE_RUNNING_MS constant used…
46e3bbf
… in polling loop

fix(tables): capture rowSel before await in delete handler; handle cl…
6f93d34
…ipboard NotAllowedError

fix(tables): abort cut on clipboard NotAllowedError to prevent silent…
8342607
… cell deletion

fix(tables): push undo before chunkBatchUpdates to survive partial ch…
691746d
…unk failures

fix(tables): use text input for number cells; idle poll backoff; csv …
fa77b7f
…error toast; column-cut drain

improvement(tables): cleanup — extract components, stabilize callback…
783d397
…s, fix ref sync

test(tables): remove background-drain describe block (behavior intent…
bf98e8c
…ionally removed)

fix(tables): surface CSV import error toast; remove dead hasRunningGr…
e3f2da4
…oupExecution

fix(tables): make runWithoutRecording async-aware so undoRedoInProgre…
e7b5a01
…ss covers full undo execution

feat(tables): render URL cells with favicon and clickable link
685ae54

feat(tables): clickable URL cells with favicons using tldts
290b4bf

waleedlatif1 force-pushed the fix/tabls branch from 4f5a68c to 290b4bfCompare May 9, 2026 20:04

vercelBotdeployed to Preview May 9, 2026 20:07 View deployment

cursorBot reviewed May 9, 2026
View reviewed changes

waleedlatif1 mentioned this pull request May 9, 2026
v0.6.72: tables improvements, search and replace, logs with files, impersonation fixes, md rendering, doc/pdf/pptx generation improvements #4516
Merged

waleedlatif1 merged commit c7130c6 into stagingMay 9, 2026
14 checks passed

waleedlatif1 deleted the fix/tabls branch May 9, 2026 20:21

Uh oh!

Conversation

waleedlatif1 commented May 9, 2026

Summary

Type of Change

Testing

Checklist

Uh oh!

vercelBot commented May 9, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursorBot commented May 9, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Uh oh!

Uh oh!

greptile-appsBot commented May 9, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Summary

Confidence Score: 3/5

Important Files Changed

Sequence Diagram

Comments Outside Diff (1)

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented May 9, 2026

Uh oh!

waleedlatif1 commented May 9, 2026

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented May 9, 2026

Uh oh!

waleedlatif1 commented May 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented May 9, 2026

Uh oh!

waleedlatif1 commented May 9, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

waleedlatif1 commented May 9, 2026

Uh oh!

waleedlatif1 commented May 9, 2026

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

waleedlatif1 commented May 9, 2026

Uh oh!

waleedlatif1 commented May 9, 2026

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

vercelBot commented May 9, 2026•
edited
Loading

cursorBot commented May 9, 2026•
edited
Loading

greptile-appsBot commented May 9, 2026•
edited
Loading