Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 3.8k
fix(execution): cap isolate memory at 128MB and recycle workers every 200 executions#4543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Uh oh!
There was an error while loading. Please reload this page.
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
ec435c3
fix(execution): cap isolate memory at 128MB and recycle workers every…
waleedlatif1 66c9d59
fix(execution): set IVM_MAX_EXECUTIONS_PER_WORKER env default to 100
waleedlatif1 525f193
fix(execution): raise MAX_EXECUTIONS_PER_WORKER from 100 to 200
waleedlatif1 eb6068b
fix(execution): update memory limit error messages from 256 MB to 128 MB
waleedlatif1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -183,7 +183,7 @@ async function executeCode(request, executionId) { | ||
| const externalCopies = [] | ||
| try { | ||
| isolate = new ivm.Isolate({ memoryLimit: 256 }) | ||
| isolate = new ivm.Isolate({ memoryLimit: 128 }) | ||
| if (executionId !== undefined) activeIsolates.set(executionId, isolate) | ||
| context = await isolate.createContext() | ||
| const jail = context.global | ||
| @@ -388,7 +388,7 @@ async function executeCode(request, executionId) { | ||
| stdout, | ||
| error: { | ||
| message: | ||
| 'Execution exceeded memory limit (256 MB). Reduce image sizes or split the work into smaller batches.', | ||
| 'Execution exceeded memory limit (128 MB). Reduce image sizes or split the work into smaller batches.', | ||
| name: 'MemoryLimitError', | ||
| }, | ||
| } | ||
| @@ -529,7 +529,7 @@ async function executeTask(request, executionId) { | ||
| let tPhase = tStart | ||
| try { | ||
| isolate = new ivm.Isolate({ memoryLimit: 256 }) | ||
| isolate = new ivm.Isolate({ memoryLimit: 128 }) | ||
waleedlatif1 marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| if (executionId !== undefined) activeIsolates.set(executionId, isolate) | ||
| context = await isolate.createContext() | ||
| const jail = context.global | ||
| @@ -945,7 +945,7 @@ async function executeTask(request, executionId) { | ||
| stdout, | ||
| error: { | ||
| message: | ||
| 'Execution exceeded memory limit (256 MB). Reduce image sizes or split the work into smaller batches.', | ||
| 'Execution exceeded memory limit (128 MB). Reduce image sizes or split the work into smaller batches.', | ||
| name: 'MemoryLimitError', | ||
| }, | ||
| timings, | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -128,7 +128,7 @@ const DISTRIBUTED_MAX_INFLIGHT_PER_OWNER = | ||
| Number.parseInt(env.IVM_DISTRIBUTED_MAX_INFLIGHT_PER_OWNER) || | ||
| MAX_ACTIVE_PER_OWNER + MAX_QUEUED_PER_OWNER | ||
| const DISTRIBUTED_LEASE_MIN_TTL_MS = Number.parseInt(env.IVM_DISTRIBUTED_LEASE_MIN_TTL_MS) || 120000 | ||
| const MAX_EXECUTIONS_PER_WORKER = Number.parseInt(env.IVM_MAX_EXECUTIONS_PER_WORKER) || 500 | ||
| const MAX_EXECUTIONS_PER_WORKER = Number.parseInt(env.IVM_MAX_EXECUTIONS_PER_WORKER) || 200 | ||
waleedlatif1 marked this conversation as resolved.
Uh oh!There was an error while loading. Please reload this page. | ||
| const MAX_BROKER_ARGS_JSON_CHARS = Number.parseInt(env.IVM_MAX_BROKER_ARGS_JSON_CHARS) || 262_144 | ||
| const MAX_BROKER_RESULT_JSON_CHARS = | ||
| Number.parseInt(env.IVM_MAX_BROKER_RESULT_JSON_CHARS) || 16_777_216 | ||
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.